HDFS-17299. Adding rack failure tolerance when creating a new file #6566

ritegarg · 2024-02-20T18:35:31Z

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

… Fixing test failures

… Dummy Commit

… Refactoring

…5. (apache#6537) Contributed by Shilun Fan" This reverts commit 555faf2.

hadoop-yetus · 2024-02-20T18:55:24Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/2/console in case of problems.

hadoop-yetus · 2024-02-20T21:26:52Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/3/console in case of problems.

hadoop-yetus · 2024-02-21T02:15:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 41s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 22s		trunk passed
+1 💚	compile	17m 30s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 8s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	4m 24s		trunk passed
+1 💚	mvnsite	3m 28s		trunk passed
+1 💚	javadoc	2m 55s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 31s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 44s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	2m 44s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	5m 2s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s		the patch passed
+1 💚	compile	16m 50s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	16m 50s		the patch passed
+1 💚	compile	16m 2s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	16m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 20s	/results-checkstyle-root.txt	root: The patch generated 16 new + 243 unchanged - 2 fixed = 259 total (was 245)
+1 💚	mvnsite	3m 29s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	2m 50s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 26s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 39s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	35m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 39s		hadoop-project in the patch passed.
+1 💚	unit	2m 43s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	225m 33s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 12s		The patch does not generate ASF License warnings.
		444m 45s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.tools.TestDFSAdmin

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/2/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux d18e41d85b24 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b927546`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/2/testReport/
Max. process+thread count	3430 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-21T05:21:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 56s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 32s		trunk passed
+1 💚	compile	17m 33s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 8s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	4m 23s		trunk passed
+1 💚	mvnsite	3m 29s		trunk passed
+1 💚	javadoc	3m 0s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 28s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 44s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	2m 44s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	4m 56s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 16s		the patch passed
+1 💚	compile	16m 40s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	16m 40s		the patch passed
+1 💚	compile	15m 51s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	15m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 17s	/results-checkstyle-root.txt	root: The patch generated 17 new + 244 unchanged - 2 fixed = 261 total (was 246)
+1 💚	mvnsite	3m 23s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	2m 54s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 28s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 39s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	35m 53s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 37s		hadoop-project in the patch passed.
+1 💚	unit	2m 48s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	269m 58s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 10s		The patch does not generate ASF License warnings.
		478m 49s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/3/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux e3099acb87dc 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `afbbe45`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/3/testReport/
Max. process+thread count	3149 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-21T23:06:00Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/4/console in case of problems.

hadoop-yetus · 2024-02-22T06:16:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 46s		trunk passed
+1 💚	compile	17m 29s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 5s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	4m 55s		trunk passed
+1 💚	mvnsite	3m 37s		trunk passed
+1 💚	javadoc	3m 0s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 29s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 45s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	2m 45s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	4m 59s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s		the patch passed
+1 💚	compile	16m 42s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	16m 42s		the patch passed
+1 💚	compile	16m 2s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	16m 2s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 12s	/results-checkstyle-root.txt	root: The patch generated 17 new + 243 unchanged - 2 fixed = 260 total (was 245)
+1 💚	mvnsite	3m 30s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	2m 54s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 30s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 40s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	36m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hadoop-project in the patch passed.
+1 💚	unit	2m 44s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	224m 56s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 13s		The patch does not generate ASF License warnings.
		434m 44s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/4/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux 6063e7627d1d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1eb085a`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/4/testReport/
Max. process+thread count	3702 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-22T06:30:00Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/5/console in case of problems.

hadoop-yetus · 2024-02-22T12:14:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	5m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 11s		trunk passed
+1 💚	compile	9m 27s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	8m 42s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	2m 19s		trunk passed
+1 💚	mvnsite	2m 5s		trunk passed
+1 💚	javadoc	1m 46s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 15s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 33s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	1m 33s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	2m 35s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	9m 1s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	9m 1s		the patch passed
+1 💚	compile	8m 41s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	8m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	2m 9s	/results-checkstyle-root.txt	root: The patch generated 17 new + 243 unchanged - 2 fixed = 260 total (was 245)
+1 💚	mvnsite	2m 2s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	1m 47s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 24s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 28s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	22m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 17s		hadoop-project in the patch passed.
+1 💚	unit	1m 49s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	219m 2s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		347m 35s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.TestDFSStripedOutputStream
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestErasureCodingMultipleRacks
	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.TestReadStripedFileWithDNFailure
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/5/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux 792d9ba7fe17 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `446ef9a`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/5/testReport/
Max. process+thread count	4202 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-22T17:27:37Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/6/console in case of problems.

hadoop-yetus · 2024-02-22T21:28:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 6s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 39s		trunk passed
+1 💚	compile	17m 21s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 6s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	4m 22s		trunk passed
+1 💚	mvnsite	3m 23s		trunk passed
+1 💚	javadoc	3m 1s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 28s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 45s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	2m 45s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	5m 4s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s		the patch passed
+1 💚	compile	17m 1s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	17m 1s		the patch passed
+1 💚	compile	15m 58s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	15m 58s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 19s	/results-checkstyle-root.txt	root: The patch generated 17 new + 243 unchanged - 2 fixed = 260 total (was 245)
+1 💚	mvnsite	3m 26s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	2m 53s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 31s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 39s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	42m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 33s		hadoop-project in the patch passed.
+1 💚	unit	3m 0s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	17m 33s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	asflicense	0m 54s	/results-asflicense.txt	The patch generated 44 ASF License warnings.
		244m 19s

Reason	Tests
Failed junit tests	hadoop.cli.TestHDFSCLI
	hadoop.hdfs.TestBalancerBandwidth
	hadoop.hdfs.TestWriteConfigurationToDFS
	hadoop.net.TestNetworkTopology

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/6/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux 1c3540b7a06c 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5d82123`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/6/testReport/
Max. process+thread count	559 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-23T00:48:32Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/7/console in case of problems.

hadoop-yetus · 2024-02-23T09:29:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 45s		Maven dependency ordering for branch
+1 💚	mvninstall	37m 15s		trunk passed
+1 💚	compile	21m 0s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	18m 51s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	5m 14s		trunk passed
+1 💚	mvnsite	3m 26s		trunk passed
+1 💚	javadoc	2m 56s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 56s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 41s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	2m 52s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
-1 ❌	shadedclient	5m 15s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 24s		the patch passed
+1 💚	compile	18m 31s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	18m 31s		the patch passed
+1 💚	compile	17m 22s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	17m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 41s	/results-checkstyle-root.txt	root: The patch generated 17 new + 244 unchanged - 2 fixed = 261 total (was 246)
+1 💚	mvnsite	3m 31s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	2m 53s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 27s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+0 🆗	spotbugs	0m 37s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	39m 1s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 37s		hadoop-project in the patch passed.
+1 💚	unit	2m 47s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	275m 42s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 14s		The patch does not generate ASF License warnings.
		525m 10s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/7/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint
uname	Linux 83fecec96c67 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3d6bbe6`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/7/testReport/
Max. process+thread count	3148 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-03-04T01:55:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 56s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 26s		trunk passed
+1 💚	compile	6m 52s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	6m 51s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 48s		trunk passed
+1 💚	mvnsite	2m 33s		trunk passed
+1 💚	javadoc	2m 15s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	2m 20s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	spotbugs	2m 41s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	40m 36s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	40m 59s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 59s		the patch passed
+1 💚	compile	5m 59s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	5m 59s		the patch passed
+1 💚	compile	5m 38s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	5m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 18s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 5 new + 244 unchanged - 2 fixed = 249 total (was 246)
+1 💚	mvnsite	2m 5s		the patch passed
+1 💚	javadoc	1m 33s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	2m 5s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	5m 59s		the patch passed
+1 💚	shadedclient	40m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 22s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	249m 35s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		459m 20s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/14/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1a2e1bc70518 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6e6131f`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/14/testReport/
Max. process+thread count	3045 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/14/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-03-05T12:29:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 0s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 20s		trunk passed
+1 💚	compile	2m 56s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	2m 48s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	0m 46s		trunk passed
+1 💚	mvnsite	1m 20s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 37s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	spotbugs	1m 26s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	21m 59s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	22m 13s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 7s		the patch passed
+1 💚	compile	2m 49s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	2m 49s		the patch passed
+1 💚	compile	2m 42s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	2m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 5 new + 243 unchanged - 2 fixed = 248 total (was 245)
+1 💚	mvnsite	1m 6s		the patch passed
+1 💚	javadoc	0m 52s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 27s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	3m 5s		the patch passed
+1 💚	shadedclient	20m 26s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 49s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	199m 4s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		307m 29s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux eee4d0329b53 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `eab85c6`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/testReport/
Max. process+thread count	4431 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

shahrs87 · 2024-03-05T18:09:51Z

spotbugs warning is not related to patch. So ignoring for now.
There are 3 test failures, 2 of them (TestBlockListAsLongs.testFuzz and TestLargeBlockReport.testBlockReportSucceedsWithLargerLengthLimit) are consistently failing in nightly builds.
The third test failure (TestDFSAdmin.testDecommissionDataNodesReconfig) is flaky. Created HDFS-17409 for further investigation.

This PR is ready to review again. All the comments are addressed by @ritegarg. If there are no more comment by EOD tomorrow, I will merge this PR. Cc @ayushtkn @tasanuma

tasanuma · 2024-03-06T01:13:57Z

There are some new checkstyle issues from the result of CI. Could you fix them?

ritegarg · 2024-03-06T01:21:10Z

There are some new checkstyle issues from the result of CI. Could you fix them?

Should be fixed now

hadoop-yetus · 2024-03-06T08:51:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	37m 2s		trunk passed
+1 💚	compile	6m 6s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	5m 54s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 34s		trunk passed
+1 💚	mvnsite	2m 17s		trunk passed
+1 💚	javadoc	1m 51s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	2m 21s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	spotbugs	2m 40s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	41m 8s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	41m 30s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 59s		the patch passed
+1 💚	compile	5m 55s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	5m 55s		the patch passed
+1 💚	compile	5m 42s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	5m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 22s		hadoop-hdfs-project: The patch generated 0 new + 243 unchanged - 3 fixed = 243 total (was 246)
+1 💚	mvnsite	2m 3s		the patch passed
+1 💚	javadoc	1m 32s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	2m 5s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	5m 58s		the patch passed
+1 💚	shadedclient	41m 11s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 22s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	257m 8s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		449m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/21/artifact/out/Dockerfile
GITHUB PR	#6566
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 5d10c83ee64d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f34203b`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/21/testReport/
Max. process+thread count	3044 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/21/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

shahrs87 · 2024-03-06T16:54:43Z

Will merge the PR later today. FYI.

…6566) (cherry picked from commit 58afe43)

…pache#6566)

Ritesh Garg added 8 commits February 20, 2024 10:33

[HDFS-17299] Adding rack failure tolerance when creating a new file

a95763e

[HDFS-17299] Adding rack failure tolerance when creating a new file

e5f763d

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

c964aa6

… Fixing test failures

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

ca01336

… Fixing test failures

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

82ba35d

… Fixing test failures

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

8a5f58d

… Dummy Commit

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

645e1c8

… Refactoring

[HDFS-17299] Adding rack failure tolerance when creating a new file -…

3b6505c

… Refactoring

github-actions bot added HDFS trunk labels Feb 20, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.…

b927546

…5. (apache#6537) Contributed by Shilun Fan" This reverts commit 555faf2.

github-actions bot added build Infra labels Feb 20, 2024

Adding changes from prev commits to run tests

afbbe45

Adding extraline to trigger tests

1eb085a

Adding changes to run tests

446ef9a

Adding changes to run tests

5d82123

Adding changes to run tests

3d6bbe6

Ritesh Garg and others added 5 commits March 2, 2024 13:35

PR comments

ce00db6

test

8653c9f

Addressing comments

21eeb9a

Merge branch 'RestartingTest' into HDFS-17299-Passing

f35d716

PR comments

6e6131f

ayushtkn requested review from Hexiaoqiao and tasanuma March 4, 2024 20:54

PR comments

6f1cd29

This comment was marked as outdated.

Sign in to view

Merge remote-tracking branch 'origin/trunk' into HDFS-17299-Passing

089be0d

This comment was marked as off-topic.

Sign in to view

Triggering build

066cb9b

This comment was marked as off-topic.

Sign in to view

Triggering build

eab85c6

ritegarg requested a review from ayushtkn March 5, 2024 18:05

Fixing checkstyle issues

f34203b

shahrs87 merged commit 58afe43 into apache:trunk Mar 6, 2024
1 of 5 checks passed

shahrs87 pushed a commit that referenced this pull request Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (#…

8812920

…6566) (cherry picked from commit 58afe43)

shahrs87 pushed a commit that referenced this pull request Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (#…

f62f116

…6566) (cherry picked from commit 58afe43)

ritegarg added a commit to ritegarg/hadoop that referenced this pull request Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (a…

f4fad11

…pache#6566)

ritegarg added a commit to ritegarg/hadoop that referenced this pull request Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (a…

4daa96b

…pache#6566)

ritegarg mentioned this pull request Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (… #6613

Closed

4 tasks

ritegarg added a commit to ritegarg/hadoop that referenced this pull request Mar 7, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file (a…

9b98db2

…pache#6566)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17299. Adding rack failure tolerance when creating a new file #6566

HDFS-17299. Adding rack failure tolerance when creating a new file #6566

ritegarg commented Feb 20, 2024

hadoop-yetus commented Feb 20, 2024

hadoop-yetus commented Feb 20, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 23, 2024

hadoop-yetus commented Feb 23, 2024

hadoop-yetus commented Mar 4, 2024

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as off-topic.

hadoop-yetus commented Mar 5, 2024

shahrs87 commented Mar 5, 2024

tasanuma commented Mar 6, 2024

ritegarg commented Mar 6, 2024

hadoop-yetus commented Mar 6, 2024

shahrs87 commented Mar 6, 2024

HDFS-17299. Adding rack failure tolerance when creating a new file #6566

HDFS-17299. Adding rack failure tolerance when creating a new file #6566

Conversation

ritegarg commented Feb 20, 2024

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Feb 20, 2024

hadoop-yetus commented Feb 20, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 21, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 22, 2024

hadoop-yetus commented Feb 23, 2024

hadoop-yetus commented Feb 23, 2024

hadoop-yetus commented Mar 4, 2024

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as off-topic.

hadoop-yetus commented Mar 5, 2024

shahrs87 commented Mar 5, 2024

tasanuma commented Mar 6, 2024

ritegarg commented Mar 6, 2024

hadoop-yetus commented Mar 6, 2024

shahrs87 commented Mar 6, 2024