HDFS-17632. RBF: Support listOpenFiles for routers #7075
+260
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ZanderXu
requested changes
Oct 22, 2024
| for (Map.Entry<RemoteLocation, BatchedEntries> entry : results.entrySet()) { | ||
| BatchedEntries nsEntries = entry.getValue(); | ||
| hasMore |= nsEntries.hasMore(); | ||
| for (int i = 0; i< nsEntries.size(); i++) { |
There was a problem hiding this comment.
for (int i = 0; i < nsEntries.size(); i++) {
| OpenFileEntry ofe = (OpenFileEntry) nsEntries.get(i); | ||
| if (ofe.getId() > minOfMax) { | ||
| hasMore = true; | ||
| continue; |
| // Get the largest inodeIds for each namespace, and the smallest inodeId of them | ||
| // then ignore all entries above this id to keep a consistent prevId for the next listOpenFiles | ||
| long minOfMax = Long.MAX_VALUE; | ||
| for (BatchedEntries nsEntries : results.values()) { |
There was a problem hiding this comment.
Is there a way to loop these BatchedEntries once to get the result?
It seems that the efficiency of two cycles is a bit low.
There was a problem hiding this comment.
I went with this option because this approach doesn't require changing the current protocol for listOpenFiles (id, types, path), otherwise client needs to be aware of the last id for each namespace. I think router getListing uses the same logic
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Routers don't have support for
listOpenFilesyet. Single destination paths are straightforward. Multi destination paths are joined; entries with inodeId > min(max(entry inodeIds)) are ignored to get a consistent prevId for the iterator.How was this patch tested?
UTs.