HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when exceptions occur. #7384

hfutatzhanghb · 2025-02-13T10:00:57Z

Description of PR

Consider below case:
1、We do asyncCallCounter.incrementAndGet() and find number of async calls > maxAsyncCalls, then we do asyncCallCounter.decrementAndGet() and throw new AsyncCallLimitExceededException(errMsg) in checkAsyncCall method.
2、In Client#call, we invoke releaseAsyncCall() which will do asyncCallCounter.decrementAndGet() again.

catch (Exception e) {
      if (isAsynchronousMode()) {
        releaseAsyncCall();
      }
      throw e;
    }

… exceptions occur.

hadoop-yetus · 2025-02-13T12:10:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	23m 49s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	9m 50s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	8m 54s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 36s		trunk passed
+1 💚	mvnsite	0m 52s		trunk passed
+1 💚	javadoc	0m 40s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 23s		trunk passed
+1 💚	shadedclient	22m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s		the patch passed
+1 💚	compile	9m 47s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	9m 47s		the patch passed
+1 💚	compile	8m 50s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	8m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		the patch passed
+1 💚	mvnsite	0m 51s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 29s		the patch passed
+1 💚	shadedclient	22m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 12s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		128m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/1/artifact/out/Dockerfile
GITHUB PR	#7384
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 524428b2d7da 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `220e74e`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/1/testReport/
Max. process+thread count	3149 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-13T12:16:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 20s		trunk passed
+1 💚	compile	10m 15s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	8m 54s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 38s		trunk passed
+1 💚	mvnsite	0m 53s		trunk passed
+1 💚	javadoc	0m 41s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 24s		trunk passed
+1 💚	shadedclient	22m 0s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	9m 43s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	9m 43s		the patch passed
+1 💚	compile	8m 57s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	8m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 38s		the patch passed
+1 💚	mvnsite	1m 0s		the patch passed
+1 💚	javadoc	0m 36s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	1m 22s		the patch passed
+1 💚	shadedclient	22m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 12s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		129m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/2/artifact/out/Dockerfile
GITHUB PR	#7384
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 0cc6665dc13f 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cd3893c`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/2/testReport/
Max. process+thread count	1261 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7384/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hfutatzhanghb · 2025-02-14T01:54:27Z

@Hexiaoqiao @slfan1989 @KeeProMise Sir, PTAL. when you have free time, thanks a lot.

KeeProMise

Hi, @hfutatzhanghb LGTM! thanks for your contribution!

slfan1989 · 2025-02-20T22:55:24Z

@hfutatzhanghb Thanks for the contribution! LGTM.

hfutatzhanghb · 2025-02-28T07:08:04Z

@Hexiaoqiao Sir, also cc this pr. If no more comments, please help merge it , Thanks a lot.

KeeProMise · 2025-03-13T13:08:01Z

@hfutatzhanghb thanks for your contribution! merged.

hfutatzhanghb · 2025-03-13T13:09:36Z

Thanks @slfan1989 for reviewing~ Thanks @KeeProMise for reviewing and merging!

… exceptions occur. (apache#7384). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <[email protected]>

github-actions bot added trunk Common labels Feb 13, 2025

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when…

cd3893c

… exceptions occur.

hfutatzhanghb force-pushed the HADOOP-19452 branch from 220e74e to cd3893c Compare February 13, 2025 10:05

KeeProMise approved these changes Feb 14, 2025

View reviewed changes

KeeProMise merged commit b73796a into apache:trunk Mar 13, 2025
1 of 3 checks passed

YanivKunda pushed a commit to YanivKunda/hadoop that referenced this pull request Mar 23, 2025

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when…

1092647

… exceptions occur. (apache#7384). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when exceptions occur. #7384

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when exceptions occur. #7384

Uh oh!

hfutatzhanghb commented Feb 13, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Feb 13, 2025

Uh oh!

hadoop-yetus commented Feb 13, 2025

Uh oh!

hfutatzhanghb commented Feb 14, 2025

Uh oh!

KeeProMise left a comment

Uh oh!

slfan1989 commented Feb 20, 2025

Uh oh!

hfutatzhanghb commented Feb 28, 2025

Uh oh!

Uh oh!

KeeProMise commented Mar 13, 2025

Uh oh!

hfutatzhanghb commented Mar 13, 2025

Uh oh!

Uh oh!

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when exceptions occur. #7384

HADOOP-19452. Client#call decrease asyncCallCounter incorrectlly when exceptions occur. #7384

Uh oh!

Conversation

hfutatzhanghb commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Uh oh!

hadoop-yetus commented Feb 13, 2025

Uh oh!

hadoop-yetus commented Feb 13, 2025

Uh oh!

hfutatzhanghb commented Feb 14, 2025

Uh oh!

KeeProMise left a comment

Choose a reason for hiding this comment

Uh oh!

slfan1989 commented Feb 20, 2025

Uh oh!

hfutatzhanghb commented Feb 28, 2025

Uh oh!

Uh oh!

KeeProMise commented Mar 13, 2025

Uh oh!

hfutatzhanghb commented Mar 13, 2025

Uh oh!

Uh oh!

hfutatzhanghb commented Feb 13, 2025 •

edited

Loading