-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11790: TestAmFilter#testProxyUpdate fails in some networks #7478
Conversation
Hello @slfan1989 . This is a one-liner test change that keeps in sync with another recent test change in Spark. Can I please get your code review? Thank you. CC: @pan3793 |
Thanks for the contribution! LGTM. |
🎊 +1 overall
This message was automatically generated. |
… Contributed by Chris Nauroth. Reviewed-by: Cheng Pan <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
@cnauroth I cherry-pick this pr to branch-3.4. cc: @steveloughran |
Thank @slfan1989 and @pan3793 ! |
Description of PR
JIRA: YARN-11790: TestAmFilter#testProxyUpdate fails in some networks.
While working on SPARK-51408, I discovered an issue that can cause their
AmIpFilterSuite#testProxyUpdate
to fail in certain unusual network setups. This test is a fork of a YARN test from Hadoop. As part of the solution, I included some additional randomization on a fake host name intended to simulate an unresolvable host. I'd like to bring the same change back into the original YARN test to make sure this doesn't become a problem in Hadoop test runs and we keep the code in sync.How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?