HDFS-17830. Fix failing TestZKDelegationTokenSecretManagerImpl due to static Curator reuse.#7960
Merged
slfan1989 merged 1 commit intoapache:trunkfrom Sep 14, 2025
Merged
Conversation
… static Curator reuse.
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
LGTM. |
slfan1989
approved these changes
Sep 14, 2025
Contributor
|
@zhtttylz Thanks for the contribution! Merged into trunk. |
Contributor
Author
|
Thanks @slfan1989 help review and merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HDFS-17830. Fix failing TestZKDelegationTokenSecretManagerImpl due to static Curator reuse.
TestZKDelegationTokenSecretManagerImpl tests fail with “Expected state [STARTED] was [STOPPED]” due to static Curator reuse
CI evidence:
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/2051/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
Under JUnit 5’s PER_METHOD lifecycle, static fields persist; this suite shares a static CuratorFramework that some tests close without resetting, so later tests reuse a STOPPED client and fail in ZKDelegationTokenSecretManagerImpl (“Expected [STARTED] was [STOPPED]”). It’s an isolation/cleanup issue, not a Curator change—reset or recreate the static client between tests (in @AfterEach).
How was this patch tested?
CI Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?