Skip to content

Comments

YARN-11931. Fix router webapp tests by adding EclipseLink test dependency.#8261

Merged
slfan1989 merged 2 commits intoapache:trunkfrom
slfan1989:YARN-11931
Feb 22, 2026
Merged

YARN-11931. Fix router webapp tests by adding EclipseLink test dependency.#8261
slfan1989 merged 2 commits intoapache:trunkfrom
slfan1989:YARN-11931

Conversation

@slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Feb 21, 2026

Description of PR

YARN-11931. Fix router webapp tests by adding EclipseLink test dependency.

After upgrading to Jersey 2.46, TestRouterWebServicesREST and TestFederationWebApp fail with NoClassDefFoundError for org.eclipse.persistence.internal.queries.ContainerPolicy.

This patch adds org.eclipse.persistence:org.eclipse.persistence.core as a test dependency in hadoop-yarn-server-router/pom.xml.

Additionally, fixed a classpath concatenation bug in JavaProcess.java where File.pathSeparator was missing when appending test resources path.

Test Results:

  • TestRouterWebServicesREST: 42 tests passed
  • TestFederationWebApp: 52 tests passed

TestRouterWebServicesREST

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.18 s -- in org.apache.hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------

TestFederationWebApp

[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.1 s -- in org.apache.hadoop.yarn.server.router.webapp.TestFederationWebApp
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:20 min
[INFO] Finished at: 2026-02-21T14:19:09+08:00
[INFO] ------------------------------------------------------------------------

How was this patch tested?

Exists Junit Test.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

…ency.

After upgrading to Jersey 2.46, TestRouterWebServicesREST and
TestFederationWebApp fail with NoClassDefFoundError for
org.eclipse.persistence.internal.queries.ContainerPolicy.

This patch adds org.eclipse.persistence:org.eclipse.persistence.core
as a test dependency in hadoop-yarn-server-router/pom.xml.

Additionally, fixed a classpath concatenation bug in JavaProcess.java
where File.pathSeparator was missing when appending test resources path.

Test Results:
- TestRouterWebServicesREST: 42 tests passed
- TestFederationWebApp: 52 tests passed
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 43m 14s trunk passed
+1 💚 compile 0m 53s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 0m 55s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 0m 52s trunk passed
+1 💚 mvnsite 0m 58s trunk passed
+1 💚 javadoc 0m 57s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 54s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 23s trunk passed
+1 💚 shadedclient 28m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 25s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 0m 25s the patch passed
+1 💚 compile 0m 25s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 0m 25s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 mvnsite 0m 28s the patch passed
+1 💚 javadoc 0m 24s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 24s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 0s the patch passed
+1 💚 shadedclient 27m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 14m 11s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt hadoop-yarn-server-router in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
126m 50s
Reason Tests
Failed junit tests hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/1/artifact/out/Dockerfile
GITHUB PR #8261
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux e14adb2b8d2c 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 162d6f3
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/1/testReport/
Max. process+thread count 1318 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/1/console
versions git=2.43.0 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @slfan1989 .

@slfan1989
Copy link
Contributor Author

+1. Thank you @slfan1989 .

@cnauroth Thank you very much for reviewing the code!

YARN-11931 has been retriggered for recompilation; if Yetus comes back green, then the issues in these three unit tests—TestFederationWebApp, TestRouterWebServicesREST, and TestYarnFederationWithFairScheduler—will be fully resolved.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 43m 20s trunk passed
+1 💚 compile 0m 55s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 0m 55s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 0m 52s trunk passed
+1 💚 mvnsite 0m 57s trunk passed
+1 💚 javadoc 0m 57s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 53s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 22s trunk passed
+1 💚 shadedclient 28m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 25s the patch passed
+1 💚 compile 0m 26s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 0m 26s the patch passed
+1 💚 compile 0m 25s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 0m 25s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 mvnsite 0m 28s the patch passed
+1 💚 javadoc 0m 24s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 24s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 0m 58s the patch passed
+1 💚 shadedclient 27m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 9m 50s hadoop-yarn-server-router in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
135m 4s
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/2/artifact/out/Dockerfile
GITHUB PR #8261
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux b5cc33838ce6 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 273c25e
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/2/testReport/
Max. process+thread count 1308 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8261/2/console
versions git=2.43.0 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 merged commit b606357 into apache:trunk Feb 22, 2026
4 checks passed
@slfan1989
Copy link
Contributor Author

@cnauroth The feedback from Yetus meets expectations, and I will merge this PR into the trunk branch. Thanks again for helping with the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants