HDFS-17901. Fix getEligibleChildren not handling DatanodeInfo in excludedNodes#8386
Open
CapMoon wants to merge 3 commits intoapache:trunkfrom
Open
HDFS-17901. Fix getEligibleChildren not handling DatanodeInfo in excludedNodes#8386CapMoon wants to merge 3 commits intoapache:trunkfrom
CapMoon wants to merge 3 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
kokonguyen191
left a comment
kokonguyen191
left a comment
There was a problem hiding this comment.
Hi @CapMoon, good catch. Left some comments on some minor formatting stuff
| } else if (excludedNode instanceof DatanodeInfo) { | ||
| String nodeLocation = excludedNode.getNetworkLocation() | ||
| + "/" + excludedNode.getName(); | ||
| DatanodeDescriptor dn = (DatanodeDescriptor)getNode(nodeLocation); |
Contributor
There was a problem hiding this comment.
Nit: DatanodeDescriptor dn = (DatanodeDescriptor) getNode(nodeLocation
| if (dn == null) { | ||
| continue; | ||
| } | ||
| storageCount -= dn.hasStorageType(type)? 1 : 0; |
Contributor
There was a problem hiding this comment.
Nit: storageCount -= dn.hasStorageType(type) ? 1 : 0;
| .getSubtreeStorageCount(type); | ||
| } else if (excludedNode instanceof DatanodeInfo) { | ||
| String nodeLocation = excludedNode.getNetworkLocation() | ||
| + "/" + excludedNode.getName(); |
Contributor
There was a problem hiding this comment.
Maybe can use NetworkTopology#PATH_SEPARATOR_STR instead of magic string "/"?
Contributor
Author
|
@kokonguyen191 thx for reviewing, all adjustments have been taken, plz review them when you are available |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-17901. Fix getEligibleChildren not handling DatanodeInfo in excludedNodes
Description of PR
In
DFSNetworkTopology#getEligibleChildren(), when iterating over excludedNodes, the method only handlesDatanodeDescriptorandDFSTopologyNodeImpltypes but misses theDatanodeInfotype. This causes storageCount to be incorrectly calculated (overestimated), leading to inconsistency with the parent methodchooseRandomWithStorageType()and potentially incorrect weighted random node selection.