You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Avoid invoking tput when it is not installed, so Hadoop shell usage formatting works on minimal distros without ncurses.
Change
hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh: guard the terminal-width probe with command -v tput and fall back cleanly to the default width.
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_subcommands.bats: add a regression for the missing-tput path.
Fixed the usage formatter to skip tput when it is unavailable and added a regression for the missing-tput path. I also verified the formatter directly in a PATH without tput, and it prints cleanly now. Ready for review.
Rebased this onto current apache/trunk and force-pushed the refreshed branch. Local validation for the narrow shell change passed by sourcing hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh, simulating a PATH without tput, and verifying hadoop_generic_columnprinter still prints the expected archive-logs usage text without a tput error message. I also confirmed the branch still contains the matching bats regression in hadoop_subcommands.bats.
Follow-up push for the latest Yetus failure: the new bats test was masking more than just tput because the simulated PATH also removed fold, so the expected archive-logs output never printed in CI. I updated the test fixture to keep fold available while still simulating missing tput, then force-pushed the amended single commit. Local validation passed with the same narrowed shell repro: source hadoop-functions.sh, expose only sort and fold on PATH, unset COLUMNS, and confirm hadoop_generic_columnprinter still prints archive-logs output without a tput error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid invoking
tputwhen it is not installed, so Hadoop shell usage formatting works on minimal distros without ncurses.Change
hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh: guard the terminal-width probe withcommand -v tputand fall back cleanly to the default width.hadoop-common-project/hadoop-common/src/test/scripts/hadoop_subcommands.bats: add a regression for the missing-tputpath.JIRA
Fixes HADOOP-19758