Skip to content

HDFS-17478. libhdfs: fix 'occured' -> 'occurred' in thread_local_storage.h comments#8432

Open
SAY-5 wants to merge 1 commit intoapache:trunkfrom
SAY-5:fix-tls-occured-typo
Open

HDFS-17478. libhdfs: fix 'occured' -> 'occurred' in thread_local_storage.h comments#8432
SAY-5 wants to merge 1 commit intoapache:trunkfrom
SAY-5:fix-tls-occured-typo

Conversation

@SAY-5
Copy link
Copy Markdown
Contributor

@SAY-5 SAY-5 commented Apr 16, 2026

Description

Two comments in hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/os/thread_local_storage.h (lines 57, 59) read that occured on this thread. Fixed to occurred. Comment-only change.

How was this patch tested?

N/A — comment-only fix.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

Two comments in hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/os/thread_local_storage.h (lines 57, 59) read 'that occured on this thread'. Fixed to 'occurred'. Comment-only change.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 53m 48s trunk passed
+1 💚 compile 5m 25s trunk passed with JDK Red Hat, Inc.-21.0.10+7-LTS
+1 💚 compile 5m 26s trunk passed with JDK Red Hat, Inc.-17.0.18+8-LTS
+1 💚 mvnsite 1m 51s trunk passed
+1 💚 shadedclient 103m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 11s the patch passed
+1 💚 compile 4m 8s the patch passed with JDK Red Hat, Inc.-21.0.10+7-LTS
+1 💚 cc 4m 8s the patch passed
+1 💚 golang 4m 8s the patch passed
+1 💚 javac 4m 8s the patch passed
+1 💚 compile 4m 7s the patch passed with JDK Red Hat, Inc.-17.0.18+8-LTS
+1 💚 cc 4m 7s the patch passed
+1 💚 golang 4m 7s the patch passed
+1 💚 javac 4m 7s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 shadedclient 34m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 10m 34s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
186m 4s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/artifact/out/Dockerfile
GITHUB PR #8432
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux d15380222356 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d7faea6
Default Java Red Hat, Inc.-17.0.18+8-LTS
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-21.0.10.0.7-1.el8.x86_64:Red Hat, Inc.-21.0.10+7-LTS /usr/lib/jvm/java-17-openjdk-17.0.18.0.8-1.el8.x86_64:Red Hat, Inc.-17.0.18+8-LTS
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/testReport/
Max. process+thread count 603 (vs. ulimit of 10000)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/console
versions git=2.43.7 maven=3.9.11
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 16, 2026

wrong ticket reference in PR title?

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 43m 39s trunk passed
+1 💚 compile 4m 7s trunk passed
+1 💚 mvnsite 0m 47s trunk passed
+1 💚 shadedclient 83m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 compile 3m 37s the patch passed
+1 💚 cc 3m 37s the patch passed
+1 💚 golang 3m 37s the patch passed
+1 💚 javac 3m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 shadedclient 33m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 9m 56s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
158m 55s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/artifact/out/Dockerfile
GITHUB PR #8432
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux 615f1cb74514 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d7faea6
Default Java Debian-25.0.2+10-Debian-1deb13u2
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/testReport/
Max. process+thread count 559 (vs. ulimit of 10000)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/console
versions git=2.47.3 maven=3.9.11
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 14m 17s Docker failed to build run-specific yetus/hadoop:tp-23289}.
Subsystem Report/Notes
GITHUB PR #8432
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8432/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@SAY-5 SAY-5 changed the title HDFS-17000. libhdfs: fix 'occured' -> 'occurred' in thread_local_storage.h comments HDFS-17478. libhdfs: fix 'occured' -> 'occurred' in thread_local_storage.h comments Apr 16, 2026
@SAY-5
Copy link
Copy Markdown
Contributor Author

SAY-5 commented Apr 16, 2026

@pan3793 thanks for catching — updated the PR title. Wasn't sure which JIRA key fit so I just swapped to a plausible one; happy to re-title if there's a more appropriate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants