Skip to content

[DO-NOT-MERGE] Enable tests on GHA#8452

Draft
pan3793 wants to merge 29 commits intoapache:trunkfrom
pan3793:gha-enable-tests
Draft

[DO-NOT-MERGE] Enable tests on GHA#8452
pan3793 wants to merge 29 commits intoapache:trunkfrom
pan3793:gha-enable-tests

Conversation

@pan3793
Copy link
Copy Markdown
Member

@pan3793 pan3793 commented Apr 22, 2026

Description of PR

This PR demonstrates how to run tests in parallel on GitHub Actions, but there are a lot of issues that need to be addressed or discussed before moving forward.

Current status:

Run the GHA workflow, if a test fails or aborts, add it to exclude-tests.txt. Repeat until 5 consecutive successes.

Current goals:

  • exclude fewer than 200 test suites (classes)
  • keep all of the remaining tests running stably on GHA, within 3 hours

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

No AI usage.

Comment thread .github/workflows/tmpl_build_and_test.yml Outdated
options: --user ${{ needs.build-image.outputs.uid }}
strategy:
fail-fast: false
max-parallel: 6
Copy link
Copy Markdown
Member Author

@pan3793 pan3793 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, this runs in the contributor's forked repo, it's free but has concurrency limitations, also remember that each split requires a build, larger parallel splits consume more overall time.

include:
- comment: hdfs
modules:
-pl :hadoop-hdfs
Copy link
Copy Markdown
Member Author

@pan3793 pan3793 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this single module takes more than 4 hours to complete (even though more than 20 tests are excluded for now), we need to improve the slow tests and use tags to split it into more groups

Copy link
Copy Markdown
Member Author

@pan3793 pan3793 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, it actually takes 5 hours to complete (with ~30 tests excluded).

I split it into 2 groups:

  • slow, ~70 classes, which single test class takes more than 60s, all of them take ~150min
  • other, the rest of them

hope it can be completed in 2.5 hours next round

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajfabbri, given the situation, I expect we may

  • exclude fewer than 200 test classes
  • keep others running stable on GHA, within 3 hours

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ready but almost here, with ~160 test suites (classes) excluded, all remaining tests run successfully in 2.5h

https://github.com/pan3793/hadoop/actions/runs/24870046901

I still need to re-run several rounds to ensure the initial test list runs stably.

@ajfabbri @steveloughran @slfan1989 would be great if you could take a look first.

@pan3793 pan3793 force-pushed the gha-enable-tests branch 4 times, most recently from 8a5ffe4 to 1dcdec9 Compare April 23, 2026 02:34
@apache apache deleted a comment from hadoop-yetus Apr 23, 2026
@apache apache deleted a comment from hadoop-yetus Apr 23, 2026
@apache apache deleted a comment from hadoop-yetus Apr 23, 2026
@apache apache deleted a comment from hadoop-yetus Apr 23, 2026
@apache apache deleted a comment from hadoop-yetus Apr 23, 2026
@pan3793 pan3793 force-pushed the gha-enable-tests branch 2 times, most recently from 2dffde6 to 30c19c0 Compare April 23, 2026 15:32
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@apache apache deleted a comment from hadoop-yetus Apr 24, 2026
@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+0 🆗 yamllint 0m 1s yamllint was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 73 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 10s Maven dependency ordering for branch
+1 💚 mvninstall 26m 35s trunk passed
+1 💚 compile 8m 34s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 8m 52s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 3m 6s trunk passed
+1 💚 mvnsite 9m 43s trunk passed
+1 💚 javadoc 6m 4s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 5m 59s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
-1 ❌ spotbugs 19m 19s /branch-spotbugs-root-warnings.html root in trunk has 92 extant spotbugs warnings.
+1 💚 shadedclient 15m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 22m 4s the patch passed
+1 💚 compile 8m 33s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 8m 33s the patch passed
+1 💚 compile 8m 52s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 8m 52s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 1s the patch passed
+1 💚 mvnsite 9m 39s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 6m 0s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 5m 55s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 25m 3s the patch passed
+1 💚 shadedclient 34m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 626m 15s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 9s The patch does not generate ASF License warnings.
847m 58s
Reason Tests
Failed junit tests hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/21/artifact/out/Dockerfile
GITHUB PR #8452
Optional Tests dupname asflicense codespell detsecrets mvnsite markdownlint yamllint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle shellcheck xmllint
uname Linux e53198cb0b25 5.15.0-171-generic #181-Ubuntu SMP Fri Feb 6 22:44:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7f2a44d
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/21/testReport/
Max. process+thread count 4144 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/21/console
versions git=2.43.0 maven=3.9.11 spotbugs=4.9.7 shellcheck=0.9.0
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+0 🆗 yamllint 0m 1s yamllint was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 73 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 1m 54s Maven dependency ordering for branch
+1 💚 mvninstall 29m 58s trunk passed
+1 💚 compile 9m 48s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 10m 17s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 3m 15s trunk passed
+1 💚 mvnsite 9m 36s trunk passed
+1 💚 javadoc 6m 0s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 6m 0s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
-1 ❌ spotbugs 20m 34s /branch-spotbugs-root-warnings.html root in trunk has 92 extant spotbugs warnings.
+1 💚 shadedclient 19m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 22m 54s the patch passed
+1 💚 compile 8m 29s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 8m 29s the patch passed
+1 💚 compile 8m 54s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 8m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 59s the patch passed
+1 💚 mvnsite 9m 42s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 5m 49s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 5m 49s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 27m 39s the patch passed
+1 💚 shadedclient 38m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 628m 11s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
865m 56s
Reason Tests
Failed junit tests hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
hadoop.yarn.server.router.webapp.TestFederationWebApp
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/25/artifact/out/Dockerfile
GITHUB PR #8452
Optional Tests dupname asflicense codespell detsecrets mvnsite markdownlint yamllint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle shellcheck xmllint
uname Linux 9d35adfb400a 5.15.0-171-generic #181-Ubuntu SMP Fri Feb 6 22:44:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7b265f8
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/25/testReport/
Max. process+thread count 3889 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/25/console
versions git=2.43.0 maven=3.9.11 spotbugs=4.9.7 shellcheck=0.9.0
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 22s #8452 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8452/27/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants