HDFS-17912. HttpFS: honor HTTPFS_CONFIG when sourcing httpfs-env.sh#8456
Open
eubnara wants to merge 1 commit intoapache:trunkfrom
Open
HDFS-17912. HttpFS: honor HTTPFS_CONFIG when sourcing httpfs-env.sh#8456eubnara wants to merge 1 commit intoapache:trunkfrom
eubnara wants to merge 1 commit intoapache:trunkfrom
Conversation
hadoop-httpfs.sh sourced httpfs-env.sh from HADOOP_CONF_DIR only,
even though HTTPFS_CONFIG is already honored for -Dhttpfs.config.dir
in the same script. Use ${HTTPFS_CONFIG:-${HADOOP_CONF_DIR}} so both
paths agree. Backward compatible.
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Pull request overview
Aligns hadoop-httpfs.sh behavior so that httpfs-env.sh is sourced from the same configuration directory that -Dhttpfs.config.dir already uses (i.e., honoring HTTPFS_CONFIG when set).
Changes:
- Source
httpfs-env.shfrom${HTTPFS_CONFIG:-${HADOOP_CONF_DIR}}instead of always${HADOOP_CONF_DIR}. - Keeps backward-compatible defaulting to
HADOOP_CONF_DIRwhenHTTPFS_CONFIGis unset/empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
hadoop-httpfs.sh sourced httpfs-env.sh from HADOOP_CONF_DIR only, even though HTTPFS_CONFIG is already honored for -Dhttpfs.config.dir in the same script. Use ${HTTPFS_CONFIG:-${HADOOP_CONF_DIR}} so both paths agree. Backward compatible.
See description on https://issues.apache.org/jira/browse/HDFS-17912, please.
How was this patch tested?
Manually test on private cluster
For code changes: