Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

HAWQ-1553 Add option to hawq extract to specify log directory #1313

Closed
wants to merge 1 commit into from

Conversation

outofmem0ry
Copy link
Contributor

No description provided.

@outofmem0ry
Copy link
Contributor Author

@radarwave Can you please review this, will be submitting a different PR to docs repo to update documentation.

return parser


def main(args=None):
parser = create_opt_parser('%prog version $Revision: #1 $')

options, args = parser.parse_args(args)
setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(), logdir=options.logDir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If user doesn't give a logdir, the default value of options.logDir is?
Anyway, just make sure there is no problem.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@interma - setup_tool_logging defaults the value of logdir to None and handles it inside the function as seen from here. I tested it locally and it works fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM.

@radarwave
Copy link
Contributor

+1

@outofmem0ry
Copy link
Contributor Author

@radarwave Submitted PR for documentation apache/hawq-docs#134

@radarwave
Copy link
Contributor

Already merged, please close this PR. Thanks.

@outofmem0ry outofmem0ry closed this Dec 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants