This repository was archived by the owner on Jul 23, 2024. It is now read-only.
HAWQ-1553 Add option to hawq extract to specify log directory #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radarwave Can you please review this, will be submitting a different PR to docs repo to update documentation. |
interma
reviewed
Nov 21, 2017
| return parser | ||
|
|
||
|
|
||
| def main(args=None): | ||
| parser = create_opt_parser('%prog version $Revision: #1 $') | ||
|
|
||
| options, args = parser.parse_args(args) | ||
| setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(), logdir=options.logDir) |
There was a problem hiding this comment.
If user doesn't give a logdir, the default value of options.logDir is?
Anyway, just make sure there is no problem.
Thanks!
|
+1 |
|
@radarwave Submitted PR for documentation apache/hawq-docs#134 |
|
Already merged, please close this PR. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.