HBASE-29349 Upgrade to opentelemetry-semconv 1.32.0 #7016
+31
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NihalJain
commented
May 22, 2025
| * Conventions</a>. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public final class HBaseSemanticAttributes { | ||
| public static final AttributeKey<String> DB_SYSTEM = SemanticAttributes.DB_SYSTEM; | ||
| public static final String DB_SYSTEM_VALUE = SemanticAttributes.DbSystemValues.HBASE; | ||
| public static final AttributeKey<String> DB_SYSTEM = DbIncubatingAttributes.DB_SYSTEM; |
There was a problem hiding this comment.
Most of these have been deprecated, we need to see whether we want to continue using these
NihalJain
commented
May 22, 2025
| public static final String EXCEPTION_EVENT_NAME = SemanticAttributes.EXCEPTION_EVENT_NAME; | ||
| public static final AttributeKey<String> EXCEPTION_TYPE = ExceptionAttributes.EXCEPTION_TYPE; | ||
| public static final AttributeKey<String> EXCEPTION_MESSAGE = ExceptionAttributes.EXCEPTION_MESSAGE; | ||
| public static final String EXCEPTION_EVENT_NAME = "exception"; |
There was a problem hiding this comment.
This key has been removed with no replacement
NihalJain
force-pushed
the
telemetry_non_alpha
branch
from
21cf6d5 to
3b16293
Compare
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved to opentelemetry latest packages with HBASE-29349 but deliberately chose to not jump to latest for semconv as it introduces few deprecations, which if removed can cause incompatibilities. With this task we want to see best approach to move to latest semconv and how to deal with these deprecations.
SemanticAttributes.java has been removed and broken down into following with semantic-conventions-java#v1.30.0-rc.1
Also there has been a few deprecations, for example refer db-migration.md
db.systemhas been deprecated and renamed todb.system.namedb.operationhas been deprecated and renamed todb.operation.nameBut with first draft of this change we continue to use the deprecated names.
If we decide on following the migration guide we can remove and handle the change as suggested in the guide or simply change them and break the compatibility.
Docs: