-
Notifications
You must be signed in to change notification settings - Fork 3.3k
HBASE-29359 VerifyReplication needs to join on its verification tasks #7041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hopefully this is more aligned with the original author's intention. Let me see try it out... FYI @hgromer . |
@@ -156,7 +162,96 @@ public enum Counters { | |||
private int sleepMsBeforeReCompare; | |||
private String delimiter = ""; | |||
private boolean verbose = false; | |||
private int batch = -1; | |||
|
|||
private ResultScanner initializeMapperOnFirstValue(Context context, Result value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the whole if-block up into this method.
@@ -340,20 +405,6 @@ protected void cleanup(Context context) { | |||
throw new RuntimeException("Failed to await executor termination in cleanup", e); | |||
} | |||
} | |||
if (replicatedScanner != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we closed down the threadpool while there was still work to do. Re-ordered those steps so that the final counter work can also run in parallel.
@@ -131,6 +134,9 @@ public class VerifyReplication extends Configured implements Tool { | |||
*/ | |||
public static class Verifier extends TableMapper<ImmutableBytesWritable, Put> { | |||
|
|||
private ThreadPoolExecutor reCompareExecutor = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Executor and its helper methods are only used from within the Map task, so moved them in here. It's possible that some MR environment will instantiate multiple map task instances per JVM, which would result in all tasks sharing the same pool, but I don't think that's how MRv2 works.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Test failures look related. |
Okay these are broken on master :( |
FYI @charlesconnell . I didn't make time to investigate this further today, so pinging you now. I do intend to take a look myself, but maybe not until tomorrow at this point. |
The test command I'm using locally is
|
No description provided.