HBASE-28962 Meta replication is inconsistent after startup when reusi… #7046
+129
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardantal
force-pushed
the
HBASE-28962-2.6
branch
from
5913f89 to
74ee25f
Compare
This comment has been minimized.
This comment has been minimized.
…ng hbase storage location (apache#6448) Signed-off-by: Andor Molnár <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
richardantal
force-pushed
the
HBASE-28962-2.6
branch
from
74ee25f to
31d7b6b
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Jun 1, 2025
There was a problem hiding this comment.
Please do not merge this.
Checked the code on branch-2.6, we also load the meta replica locations from master local region, not zookeeper. So the comment here is incorrect
Please also revert the changes from existing branches, and let's review what is the root cause of this problem.
Thanks.
|
We run into this issue from time to time. When creating a cluster with storage location set to a storage location of an earlier cluster. Both clusters are set to use meta replication. Do you think this change could cause any problems? |
I agree that before identifying the root cause, you can apply some temporary approaches on your internal branches to 'fix' the problem. But on the open source branch, I think we should find the root cause and then apply the 'correct' fix. As I've said above, please check whether we have the master local region related changes in your internal branch. And on the unit testing, please try delete everything on zookeeper to simulate your scenario. You can see HBASE-29292 and TestRecreateCluster on how to do this. If you can still produce the problem, we can check again whether we need the changes here. Thanks. |
@Apache9 is right, since HBASE-26193, present since 2.5.0, we don't rely on ZK for the region states anymore. @richardantal , have you still managed to reproduce this issue on a 2.5/2.6 based deployment? |
wchevreuil
added a commit
to wchevreuil/hbase
that referenced
this pull request
Jun 2, 2025
… startup when reusing hbase storage location (apache#6448)" As discussed further on apache#7046, the described issue may not apply to branches containing the changes from HBASE-26193 (present since 2.5.0). This reverts commit 08621f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng hbase storage location (#6448)