HBASE-30303: Fix balancing for regions assigned through RSGroup fallback - #8519
Open
Sigma-Ma wants to merge 1 commit into
Open
HBASE-30303: Fix balancing for regions assigned through RSGroup fallback#8519Sigma-Ma wants to merge 1 commit into
Sigma-Ma wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30303
What changes were proposed in this pull request?
This pull request updates
RSGroupBasedLoadBalancer#correctAssignmentsto use the same candidate-server selection logic as region assignment when RSGroup fallback is enabled.When the target RSGroup has no online RegionServers,
correctAssignmentsnow validates region locations against the effective fallback candidates.The existing
TestRSGroupsFallbacktest is also extended to verify that no region moves are calculated when regions are correctly hosted on fallback servers.Why are the changes needed?
When RSGroup fallback is enabled and a table's target RSGroup has no online RegionServers, its regions are assigned to the default RSGroup, or to any available RegionServer if the default group is also unavailable.
Previously,
correctAssignmentsonly validated these regions against the table's original RSGroup. Therefore, regions already hosted on valid fallback servers were incorrectly classified as misplaced during every balance run, resulting in continuous and unnecessary region movement.How was this patch tested?
The following tests were executed:
TestRSGroupsFallbackverifies that balancing calculates no moves after regions fall back to the default RSGroup and after they fall back to another available RSGroup.