fix: avoid blocking modify monitor by redundant detect call#4154
Open
wilmerdooley wants to merge 1 commit into
Open
fix: avoid blocking modify monitor by redundant detect call#4154wilmerdooley wants to merge 1 commit into
wilmerdooley wants to merge 1 commit into
Conversation
Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Removed the synchronous
detectMonitorinvocation from themodifyMonitorflow inMonitorServiceImpl. Previously, updating a monitor's settings (such as the collect interval) would trigger an immediate detection pass while still holding the monitor lock, which could block the request for a long time and eventually cause the API to time out even though the save itself succeeded.The detection is no longer required as part of the update path; the collector will pick up the new configuration on its next scheduled run. This makes the
modify monitorendpoint return promptly and prevents the misleading timeout-on-successful-save behavior reported by users.Resolves #3812
Checklist
Add or update API