HIVE-29386: Fix hmsbench runtime error on jdk21 #6250
Conversation
|
|
LGTM +1 |
| <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> | ||
| <mainClass>org.apache.hadoop.hive.metastore.tools.BenchmarkTool</mainClass> | ||
| <manifestEntries> | ||
| <Multi-Release>true</Multi-Release> |
There was a problem hiding this comment.
I checked the dnsjava:3.6.1 jar and META-INF/versions/11 and META-INF/versions/18 were make sense to set Multi-Release to true.
There was a problem hiding this comment.
I don't have full understanding of it. Could you explain a bit more please? what's if we dont add this entries
There was a problem hiding this comment.
@dengzhhu653 , dnsjava-3.6.1 is a multi-release jar and after shading the Multi-Release tag is getting dropped from MANIFEST.MF.
I was able to repro the ERROR message present on the JIRA .
Before and after the fix,META-INF/MANIFEST.MF on hmsbench.jar
I didn't explored if there is any other way to fix this.
There was a problem hiding this comment.
Here is a related discussion dnsjava/dnsjava#329, Multi-Release is a recommended solution.
|
@zhangbutao @dengzhhu653 @zabetak could you also take a look? |
4 participants
What changes were proposed in this pull request?
Why are the changes needed?
Fix bug to make hmsbench.jar workable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run benchmark test locally.