HIVE-29360: Add tests for EXPLAIN FORMATTED CBO on TPC-DS queries #6254
+310,142
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
LGTM +1 (Haven't gone through q.out) |
Member
Author
|
@soumyakanti3578 since you are familiar with this work can you take a look? |
soumyakanti3578
approved these changes
Jan 7, 2026
Contributor
soumyakanti3578
left a comment
soumyakanti3578
left a comment
There was a problem hiding this comment.
Looks good to me! 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Increase test coverage for
EXPLAIN FORMATTED CBOoutput and guard against regressions. The existing coverage is very limited and restricted to very simple queries. Adding output for the TPC-DS queries creates a reasonable baseline.Does this PR introduce any user-facing change?
No
How was this patch tested?
The tests take ~200 sec when run locally.