Issue #8163 : Harden XmlInputStream StAX factory against XXE - #8164
Draft
mattcasters wants to merge 1 commit into
Draft
Issue #8163 : Harden XmlInputStream StAX factory against XXE#8164mattcasters wants to merge 1 commit into
mattcasters wants to merge 1 commit into
Conversation
Disable DTD processing and external entity resolution on StAX XMLInputFactory via XmlParserFactoryProducer, and use that factory from XmlInputStream and the remaining raw/partial StAX call sites.
hansva
marked this pull request as draft
August 29, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8163
XmlInputStreamcreated a raw StAXXMLInputFactoryand never disabled DTD processing or external entity resolution. Other Hop XML parsers already go throughXmlParserFactoryProducer(DOM/SAX/Schema) or set the two StAX flags locally.This adds
XmlParserFactoryProducer.createSecureXmlInputFactory()(SUPPORT_DTD=false,IS_SUPPORTING_EXTERNAL_ENTITIES=false, best-effortACCESS_EXTERNAL_DTD/SCHEMA) and uses it from:XmlInputStream(the reported sink)WebService(SOAP/HTTP responses)XmlFormatterAdvancedXmlOutputand ExcelStaxUtil(already local flags; they now share the helper)Behavior change: XML documents that contain a DOCTYPE will fail to parse. That is the intended trade-off.
Tests
XmlUtilsTestXmlInputStreamTestregression that the canary is not emitted as row dataTargeted unit tests:
./mvnw -pl core,plugins/transforms/xml,plugins/transforms/excel,plugins/transforms/webservices -am test -Pskip-uitestThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.