Fix classloader for commit operation in flink coordinator #13901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshuo
changed the title
cshuo
force-pushed
the
fix_classloader_102
branch
from
25daa24 to
55fb21d
Compare
cshuo
changed the title
danny0405
changed the title
danny0405
changed the title
danny0405
reviewed
Sep 17, 2025
| // multiple userCode context classloaders may register same region server metric which leads to validating exception in | ||
| // `DefaultMetricsSystem#newSourceName`. So here we set the init mode for hadoop metrics as `STANDBY` to disable metric | ||
| // registering for HFile writer. | ||
| System.setProperty("hadoop.metrics.init.mode", "STANDBY"); |
There was a problem hiding this comment.
Does the issue exist on master? guess no because Hbase jar has been removed? Also there is no need to set it up every time for MDT commit? Just set up once in coordinator #initMetadataTable should be enough?
There was a problem hiding this comment.
Yes, the issue only exists before 1.1.
We can put the setting up in #initMetadataTable, but my concern is hadoop.metrics.init.mode is not only for hbase metric, it's a hadoop configuration, and not sure whether it'll affect the initialization of other component's metric, so I incline to delay setting this configuration until the HFile writer initialization is required.
cshuo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Fix coordinator commit classloader
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist