Skip to content

Conversation

rahil-c
Copy link
Contributor

@rahil-c rahil-c commented Oct 2, 2025

Describe the issue this Pull Request addresses

  • This PR seeks to add coverage for tables on v6 with common payloads such as OverwriteWithLatestAvroPayload and DefaultHoodieRecordPayload.

Summary and Changelog

  • Minor refactoring changes around passing a tableVersion as before this test class was hard coded to do the upgrade and downgrade flow from 8 -> 9 and 9 -> 8. Now we run the same flows for table version 6 as well.
  • Added a seperate test case provider for v6 cases which will be supplied to only the test testMergerBuiltinPayloadUpgradeDowngradePath.

Impact

None

Risk Level

None

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Oct 2, 2025
@linliu-code
Copy link
Contributor

@rahil-c , after this change, no any expected data change?

def getExpectedResultForSnapshotQuery(payloadClazz: String, usesDeleteMarker: Boolean): Seq[(Int, Long, String, String, Double, String, String, Int, Int, String)] = {
def getExpectedResultForSnapshotQuery(payloadClazz: String, usesDeleteMarker: Boolean, hasOrderingField: Boolean, tableType: String, startVersion: String = "8"): Seq[(Int, Long, String, String, Double, String, String, Int, Int, String)] = {
// V6 backward compatibility: OverwriteWithLatestAvroPayload with MOR + ordering field uses EVENT_TIME
val isV6BackwardCompatCase = startVersion == "6" &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove this now as we are not covering this case in this test, and will be doing a different approach

@hudi-bot
Copy link

hudi-bot commented Oct 3, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants