[DO NOT MERGE] refactor(spark): Rework tests that disable FileGroup Reader in Spark #14061
+298
−1,204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvex
changed the title
jonvex
force-pushed
the
remove_fg_reader_disabled_tests_spark
branch
from
0fa87a0 to
296a6bb
Compare
github-actions
bot
added
size:XL
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
do not merge. Currently ontop: #14060
We are going to be removing support for fg reader disabled in spark. Therefore, we must rework any test that has the filegroup reader disabled.
Summary and Changelog
So far, just throw an exception if fg reader is disabled
Impact
removing support for non-fg reader path in spark
Risk Level
low
Documentation Update
N/A
Contributor's checklist