fix: Persist RLI index bootstrap records only if estimation is required and add unpersist #14069
+27
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and add unpersist
|
Verified locally that persist and unpersist is working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Closes #14068 #14068
Summary and Changelog
If the min and max file group count for record index is configured and set to the same value, record index records should will not be persisted. We would use the configured value as the file group count instead of estimating it in such a case.
Impact
PR adds an optimisation where record index records will not be persisted if file group count is configured by the user. Also the record index records were not unpersisted after bootstrap. The PR adds unpersist after bootstrap of record index partition.
Risk Level
Low
Documentation Update
NA
Contributor's checklist