Skip to content

feat(client): support graphspace#633

Merged
imbajin merged 32 commits intoapache:masterfrom
Thespica:client-support-gs
Feb 24, 2025
Merged

feat(client): support graphspace#633
imbajin merged 32 commits intoapache:masterfrom
Thespica:client-support-gs

Conversation

@Thespica
Copy link
Contributor

@Thespica Thespica commented Oct 23, 2024 •
edited by imbajin
Loading

Purpose of the PR

Main Changes

Also compatible with non-GS graph server (when gs=DEFAULT & graph version < 2.0)

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 23, 2024
@github-actions github-actions bot added the client hugegraph-client label Oct 23, 2024
@Thespica Thespica mentioned this pull request Oct 26, 2024
Open
@Thespica Thespica changed the title [WIP]feat(client): support graphspace feat(client): support graphspace Nov 15, 2024
@Thespica
Copy link
Contributor Author

Thespica commented Nov 17, 2024

@imbajin @VGalaxies
This PR is ready, please take a review : )

@apache apache deleted a comment from github-actions bot Dec 20, 2024
@imbajin imbajin requested review from imbajin and javeme December 20, 2024 08:08
@github-actions github-actions bot removed the inactive label Dec 20, 2024
@Pengzna Pengzna mentioned this pull request Jan 15, 2025
Open
19 tasks
@apache apache deleted a comment from github-actions bot Jan 20, 2025
@github-actions github-actions bot removed the inactive label Jan 20, 2025
@FrostyHec FrostyHec mentioned this pull request Jan 21, 2025
Open
13 tasks
@apache apache deleted a comment from github-actions bot Feb 20, 2025
@github-actions github-actions bot removed the inactive label Feb 20, 2025
imbajin
imbajin approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it first

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2025
@imbajin imbajin merged commit 43da581 into apache:master Feb 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

@VGalaxies VGalaxies VGalaxies approved these changes

@javeme javeme Awaiting requested review from javeme

Assignees

No one assigned

Labels

client hugegraph-client lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

HugeGraph Tasks
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thespica @imbajin @VGalaxies