Skip to content

fix(client): adjust Client to 1.7.0 server#689

Merged
imbajin merged 32 commits intoapache:masterfrom
sadwitdastreetz:fix-bug
Nov 4, 2025
Merged

fix(client): adjust Client to 1.7.0 server#689
imbajin merged 32 commits intoapache:masterfrom
sadwitdastreetz:fix-bug

Conversation

@sadwitdastreetz
Copy link
Contributor

Purpose of the PR

  • close #xxx

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 2, 2025
@github-actions github-actions bot added the client hugegraph-client label Nov 2, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 2, 2025
@github-actions github-actions bot added tools hugegraph-tools spark labels Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.59%. Comparing base (b066b80) to head (d5a0f5b).
⚠️ Report is 60 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b066b80) and HEAD (d5a0f5b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b066b80) HEAD (d5a0f5b)
2 1
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #689       +/-   ##
=============================================
- Coverage     62.49%   51.59%   -10.91%     
+ Complexity     1903      971      -932     
=============================================
  Files           262      111      -151     
  Lines          9541     5828     -3713     
  Branches        886      750      -136     
=============================================
- Hits           5963     3007     -2956     
+ Misses         3190     2562      -628     
+ Partials        388      259      -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sadwitdastreetz and others added 2 commits November 3, 2025 16:25
Updated HugeGraph commit ID in CI workflow files and improved code style consistency across multiple Java files by adjusting formatting, removing unnecessary blank lines, and simplifying logic.

Also added ignore rules for AI assistant prompt files in .gitignore.
sadwitdastreetz and others added 5 commits November 3, 2025 17:16
Eliminated the graphSpace property and its related methods from the Belong class to simplify the authorization structure. Also updated a comment in HugeResource for clarity.
Updated Target class to store resources as a generic Object, always using List<Map> for compatibility with server responses.

Adjusted resource getter/setter methods and test cases to use the new format, ensuring correct serialization and deserialization of resource data.
Updated Access and Belong classes to mark the graphSpace and link fields as read-only in their JSON properties.

Added graphSpace field and getter/setter to Belong for consistency with Access. This ensures these fields are not modified during deserialization.
Updated the Groovy scripts in TaskApiTest to use Gremlin's g.addV('man').iterate() instead of hugegraph.addVertex and removed explicit transaction commits.

Increased the async task loop to 100 iterations with shorter sleep intervals, simplified the waiting logic before cancelling the task, and improved the final assertion to check vertex count is less than 100. These changes streamline the test and improve reliability.
Added a wait for HugeGraph server initialization in the install script and test cases to prevent race conditions. Enhanced teardown methods in JobApiTest and TaskApiTest to cancel running tasks before deletion.

 Updated TaskApiTest to clean up vertices before insertion, ensuring tests run in a clean state.
Moved task cleanup logic to a shared method in BaseApiTest for reuse and improved error handling during cleanup. TaskApiTest now also cleans up the 'man' vertex label after tests. Cleanup methods are more resilient to exceptions, ensuring test environments are reliably reset.
imbajin and others added 4 commits November 3, 2025 19:57
Temporarily disabled three tests in GraphsApiTest using @ignore due to NullPointerException in server's metaManager.graphConfigs() when calling graphsAPI.list(). Removed waitForServerReady() and related code.

 Will re-enable after server metaManager is fixed.
Refactored UserRole roles mapping to include graphSpace, graph, permission, resourceType, and resources for finer-grained access control. Updated AuthManagerTest and MetricsManagerTest to reflect the new structure and key format.
@sadwitdastreetz sadwitdastreetz changed the title fix(client): fixed wrong ref for AuthAPI && update commit_id fix(client): adjust Client to 1.7.0 server Nov 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2025
@imbajin imbajin requested review from Pengzna and VGalaxies November 4, 2025 14:56
@imbajin imbajin merged commit 1e70a71 into apache:master Nov 4, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client hugegraph-client lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. spark tools hugegraph-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants