Skip to content

Scan Delete Support Part 5: Positional Delete Parsing #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sdd
Copy link
Contributor

@sdd sdd commented Feb 26, 2025

Continues the series of scan delete file support PRs.

Builds on top of #982: click 5504434 to see just the changes that are unique to this PR rather than the preceding ones.

  • Adds parsing of positional delete files to the DeleteFileManager
  • Updates the integration tests in crates/integration_tests/tests/shared_tests/read_positional_deletes.rs to include a working end-to-end test that processes positional deletes
  • Refactors scan.rs and arrow/reader.rs so that when delete file support is specified as being disabled, and a delete file is encountered, the error is returned from the read phase rather than the plan phase.

Issue: #630

@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch from 52d3e2c to a14c3f2 Compare February 26, 2025 19:21
@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch 3 times, most recently from e7f9102 to efc45e5 Compare March 5, 2025 20:27
@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch 2 times, most recently from 643f47a to cfe6a91 Compare April 3, 2025 07:31
@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch from cfe6a91 to a92ac96 Compare April 17, 2025 06:47
@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch from a92ac96 to 5504434 Compare April 24, 2025 06:17
@sdd sdd force-pushed the feat/delete-file-pos-del-parsing branch from 5504434 to decef64 Compare April 24, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants