Core: Pass storage credentials from LoadTableResponse to FileIO #12591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
creds-from-loadtable
branch
from
9bc2853 to
8db24df
Compare
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
creds-from-loadtable
branch
from
8db24df to
efe6592
Compare
nastra
force-pushed
the
creds-from-loadtable
branch
from
efe6592 to
716a064
Compare
nastra
changed the title
nastra
force-pushed
the
creds-from-loadtable
branch
6 times, most recently
from
7848acb to
0c21c44
Compare
nastra
force-pushed
the
creds-from-loadtable
branch
4 times, most recently
from
2f64867 to
0ca4c6b
Compare
danielcweeks
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Thanks @nastra! Passing through the credentials to the fileIO implementations looks great. Just had a comment for adding a JavaDoc on the new mixin interface since it is public.
core/src/main/java/org/apache/iceberg/io/SupportsStorageCredentials.java
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
creds-from-loadtable
branch
from
0ca4c6b to
7d75581
Compare
|
thanks for the reviews @amogh-jahagirdar and @danielcweeks |
amogh-jahagirdar
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.