GCP: Use catalog endpoint as base when refreshing OAuth2 token #12638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
gcs-use-correct-base-uri
branch
from
50deccc to
f29db13
Compare
nastra
force-pushed
the
gcs-use-correct-base-uri
branch
from
f29db13 to
73308cf
Compare
| @@ -49,6 +53,11 @@ private OAuth2RefreshCredentialsHandler(Map<String, String> properties) { | |||
| Preconditions.checkArgument( | |||
| null != properties.get(GCPProperties.GCS_OAUTH2_REFRESH_CREDENTIALS_ENDPOINT), | |||
| "Invalid credentials endpoint: null"); | |||
| Preconditions.checkArgument( | |||
| null != properties.get(CatalogProperties.URI), "Invalid catalog endpoint: null"); | |||
| this.credentialsEndpoint = | |||
There was a problem hiding this comment.
Why aren't we doing the same thing here that we do in ADLS?
RESTUtil.resolveEndpoint(
properties.get(CatalogProperties.URI),
properties.get(ADLS_REFRESH_CREDENTIALS_ENDPOINT));There was a problem hiding this comment.
we're doing it for GCP in GCPProperties:
iceberg/gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java
Lines 109 to 112 in 978189c
For ADLS we're also doing the same in
AzureProperties:
For S3 it happens in
AwsClientProperties: iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java
Lines 109 to 111 in 7d0395d
danielcweeks
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.