-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Spec: Allow the use of source-id
in V3
#12644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Mar 27, 2025
wgtmac
reviewed
Mar 27, 2025
Co-authored-by: Gang Wu <[email protected]>
I wonder should we remove multi-bucket into separate pr, to allow the source-id part to get in? |
@szehon-ho I think that's a good idea. Let me rework the PR 👍 |
81711a0
to
c103bab
Compare
rdblue
reviewed
Apr 3, 2025
jbonofre
reviewed
Apr 10, 2025
jbonofre
approved these changes
Apr 14, 2025
jbonofre
approved these changes
Apr 15, 2025
rdblue
reviewed
Apr 16, 2025
rdblue
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a typo, but overall I think this is the right direction. Thanks, @Fokko!
Fokko
commented
Apr 16, 2025
Fokko
commented
Apr 16, 2025
rdblue
approved these changes
Apr 16, 2025
szehon-ho
approved these changes
Apr 17, 2025
amogh-jahagirdar
approved these changes
Apr 17, 2025
RussellSpitzer
approved these changes
Apr 17, 2025
Looks good to me, thanks @Fokko ! |
flyrain
approved these changes
Apr 18, 2025
Fokko
added a commit
that referenced
this pull request
Apr 22, 2025
I merged a [spec-change earlier today](#12644), but noticed that it was not live on the website. I think it would be good to get these changes out right away.
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes around the multi-argument transforms, mainly two things:
The spec does not point out an actual implementations of transforms that accept multiple arguments. From the existing transforms, the only contender is the bucket transform. Should we include this in the V3 spec? It will only allow to prune metadata if you do an equality expression on all the fields that are part of the transform.