Spark, API: Enhance hashing efficiency by operating on raw UTF-8 bytes #12657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @xiaoxuandev I think the general fix is great, just had a comment about keeping the existing hash(String)
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java
Outdated
Show resolved
Hide resolved
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkBucketFunction.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Thanks @xiaoxuandev! Just had some non-blocking nits. I'll leave it open for just a bit in case others wanted to review.
| @@ -82,7 +82,12 @@ public void testSpecValues() { | |||
| Assert.assertEquals( | |||
| "Spec example: hash(\"iceberg\") = 1210000089", | |||
| 1210000089, | |||
| new BucketFunction.BucketString().hash("iceberg")); | |||
| new BucketFunction.BucketString().hash("iceberg".getBytes(StandardCharsets.UTF_8))); | |||
There was a problem hiding this comment.
Nit: We could just leave this the same as before just to keep the diff smaller.
| @@ -74,10 +74,14 @@ public void testSpecValues() { | |||
| .as("Spec example: hash(2017-11-16T22:31:08) = -2047944441") | |||
| .isEqualTo(-2047944441); | |||
|
|
|||
| assertThat(new BucketFunction.BucketString().hash("iceberg")) | |||
| assertThat(new BucketFunction.BucketString().hash("iceberg".getBytes(StandardCharsets.UTF_8))) | |||
There was a problem hiding this comment.
Nit: Same as above, we could just leave this assertion the same as earlier just to keep the diff smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unnecessary
toString()conversions by directly processing UTF-8 bytes, improving efficiency and reducing memory allocations.