-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docs: Fix list rendering and typos (#13075) #13267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix list rendering and typos (#13075) #13267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I ran this locally and attached the screenshots.
One interesting observation is that the new changes only show up in nightly
, i.e. http://127.0.0.1:8000/docs/nightly/spark-queries/#files
@@ -382,7 +382,9 @@ s3://my-table-data-bucket/my_ns.db/my_table/0101/0110/1001/10110010/category=ord | |||
``` | |||
|
|||
Note, the path resolution logic for `ObjectStoreLocationProvider` is `write.data.path` then `<tableLocation>/data`. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: There are some slight differences between these implementations: | ||
- The `RANGE` distribution mode is not yet available for the `IcebergSink` | ||
- When using `IcebergSink` use `uidSuffix` instead of the `uidPrefix` | ||
!!! warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -386,6 +386,7 @@ ALTER TABLE orders REPLACE COLUMNS (remaining string); | |||
|
|||
#### Partition evolution | |||
You change the partitioning schema using the following commands: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* 0 Data | ||
* 1 Position Deletes | ||
* 2 Equality Deletes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the docs @yelianevich, much appreciated :) And thanks everyone else for the review |
Fixes #13075
The issue with rendering list is related to a missing blank line between paragraphs and lists. I found more similar issues and fixed them in this PR as well.
Here are the screenshots of the fixed lists from the local instance: