-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Support IncrementalChangelogScan with deletes #9888
Conversation
7f0170c
to
8318f2b
Compare
…9888. This uses the BaseIncrementalChangeloggScan implementation from apache#9888 and the rest of the changes (including tests) from apache#10935 to test the BaseIncrementalChangeloggScan implementation.
You have made changes in I took my changes in #10935 and swapped out my |
context.specAsString(), | ||
context.residuals()); | ||
} else { | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is one way! ;-)
In my implementation, I use a placeholder DummyChangelogScanTask
that is filtered out.
Closed in favor of #10935 |
Pick up #6182 with an alternative implementation
cc @aokolnychyi @szehon-ho @flyrain for review