Skip to content

fix(q_dev): Add validation for empty S3 CSV file list #8537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(q_dev): Add validation for empty S3 CSV file list #8537

wants to merge 8 commits into from
+291 −33

Conversation

DiscreteTom
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  • Throw BadInput error when no CSV files found in S3 path
  • Helps users identify incorrect S3 bucket/prefix configuration
  • Extract functions for unit tests
  • Add unit tests

Does this close any open issues?

Closes xx

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p1 This bug affects functionality or significantly affect ux labels Aug 14, 2025
warren830
warren830 previously approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiscreteTom DiscreteTom force-pushed the fix-s3-empty-validation branch from 0175ef4 to ec4f579 Compare August 14, 2025 03:34
@DiscreteTom DiscreteTom force-pushed the fix-s3-empty-validation branch from bc2c484 to dfc9c8a Compare August 14, 2025 03:36
@DiscreteTom DiscreteTom requested a review from warren830 August 14, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warren830 warren830 Awaiting requested review from warren830

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p1 This bug affects functionality or significantly affect ux size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DiscreteTom @warren830