fix(dora): fix wrong change lead time calculator #8552
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary of the reviewer’s concern
deployment_commit
in a scope when mapping PRs to deployments using commit diffs, because:This PR:
Adjusts
getDeploymentCommit
to use a two-phase strategy:commit_sha
equals the PR’s merge commit, return it. This is precise and does not risk the first deployment over mapping problem.dc.prev_success_deployment_commit_id <> ''
) to avoid mapping to the first deployment via diffsDoes this close any open issues?
Closes #8188
Screenshots