Skip to content

Conversation

GoSimplicity
Copy link
Contributor

add branch filtering for Jenkins jobs #8579

GoSimplicity and others added 24 commits August 21, 2025 16:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Oct 2, 2025
@GoSimplicity GoSimplicity requested a review from klesh October 7, 2025 11:09
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading issue #8579, could the problem be that scope_api.go and remote_api.go are returning incorrect scopes?

@GoSimplicity
Copy link
Contributor Author

After reading issue #8579, could the problem be that scope_api.go and remote_api.go are returning incorrect scopes?

Thanks for the review I checked both remote_api.go and scope_api.go. You're right to question this.
From what I can see:

  • remote_api.go looks fine - MultiBranchProject is treated as a scope (it's in scopesWithJobs), so its branch jobs won't show up as selectable scopes in the UI
  • The issue in [Feature][Jenkins Connection] Introduce filtering of branch builds #8579 is different - when you select a MultiBranchProject, the collector grabs all branch jobs underneath it, converts them to cicd_pipelines, and they all show up in Grafana
    My PR filters branches during collection so only matching ones get into Grafana. But you're right that we should check if GetScopeList is also returning these auto-collected branch jobs alongside user-selected scopes.
    Should I add logic to distinguish user-selected scopes from auto-collected branch jobs? Or is filtering at collection time enough for this use case?

@petkostas petkostas changed the title feat: add branch filtering for Jenkins jobs feat(jenkins): add branch filtering for Jenkins jobs Oct 9, 2025
@klesh
Copy link
Contributor

klesh commented Oct 10, 2025

Thanks for the explanation.
@OG256 could you provide some context/input on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants