Skip to content

Conversation

@rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Feb 2, 2024

What changes were proposed in this pull request?

Spark 3.2 provides different result type with Spark 3.3 and 3.4 for decimal round. To make them work, a result type check in Velox was disabled. This PR changes to use the same result type for decimal round.

How was this patch tested?

Verified unit tests with oap-project/velox#476.

@github-actions
Copy link

github-actions bot commented Feb 2, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

github-actions bot commented Feb 2, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 2, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Feb 5, 2024

Run Gluten Clickhouse CI

@rui-mo rui-mo requested a review from JkSelf February 5, 2024 03:56
@JkSelf
Copy link
Contributor

JkSelf commented Feb 5, 2024

@rui-mo Do we need to enable related uts in gluten?

@rui-mo
Copy link
Contributor Author

rui-mo commented Feb 5, 2024

@rui-mo Do we need to enable related uts in gluten?

Relating tests for decimal round are enabled in Gluten.

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@rui-mo rui-mo merged commit 1620eeb into apache:main Feb 5, 2024
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4621_time.csv log/native_master_02_04_2024_d1b29e1bc_time.csv difference percentage
q1 31.90 33.68 1.787 105.60%
q2 24.51 24.23 -0.285 98.84%
q3 38.02 37.37 -0.650 98.29%
q4 37.66 35.96 -1.699 95.49%
q5 70.69 70.39 -0.295 99.58%
q6 6.83 6.99 0.169 102.48%
q7 82.99 84.51 1.523 101.83%
q8 82.93 84.14 1.213 101.46%
q9 120.15 121.28 1.132 100.94%
q10 42.76 43.47 0.714 101.67%
q11 19.89 20.46 0.570 102.86%
q12 24.61 26.23 1.622 106.59%
q13 46.30 45.25 -1.058 97.72%
q14 21.00 15.93 -5.076 75.83%
q15 27.16 26.74 -0.426 98.43%
q16 12.93 14.11 1.184 109.16%
q17 101.16 102.75 1.593 101.57%
q18 149.62 148.66 -0.968 99.35%
q19 12.38 13.50 1.120 109.05%
q20 28.86 26.71 -2.150 92.55%
q21 220.95 221.36 0.419 100.19%
q22 13.76 13.64 -0.117 99.15%
total 1217.05 1217.37 0.323 100.03%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants