feat: remove duplicate .clang-format and move it to top layer#850
Open
SYaoJun wants to merge 2 commits intoapache:mainfrom
Open
feat: remove duplicate .clang-format and move it to top layer#850SYaoJun wants to merge 2 commits intoapache:mainfrom
SYaoJun wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
============================================
- Coverage 80.21% 80.21% -0.01%
Complexity 615 615
============================================
Files 93 93
Lines 10257 10258 +1
Branches 1049 1050 +1
============================================
Hits 8228 8228
- Misses 1789 1790 +1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SYaoJun
force-pushed
the
duplic_clang_format
branch
3 times, most recently
from
881f038 to
0c32747
Compare
SYaoJun
force-pushed
the
duplic_clang_format
branch
from
0c32747 to
aef79e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
There are two .clang-format under different directories.
We could remove one of them and move it to top directory, then other bindings can share the same configuration.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?