Skip to content

fix(C++): fix all enumerations to use strongly-typed enums (enum class)#869

Open
SYaoJun wants to merge 1 commit intoapache:mainfrom
SYaoJun:218_enum_class
Open

fix(C++): fix all enumerations to use strongly-typed enums (enum class)#869
SYaoJun wants to merge 1 commit intoapache:mainfrom
SYaoJun:218_enum_class

Conversation

@SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Feb 18, 2026

Reason for this PR

fix: #855

Currently, our enum mixed with C-type and strongly-type. C-type enums exists implicit convertion which may lead to potential bugs in some scenerios. A better way is using strongly-type enums.

What changes are included in this PR?

Fix all C-type enums.

Are these changes tested?

N/A

Are there any user-facing changes?

N/A

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (eab0fa5) to head (79cc3d0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cpp/src/graphar/filesystem.cc 75.00% 1 Missing ⚠️
cpp/src/graphar/status.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #869      +/-   ##
============================================
- Coverage     80.21%   80.20%   -0.01%     
  Complexity      615      615              
============================================
  Files            93       93              
  Lines         10258    10259       +1     
  Branches       1050     1050              
============================================
  Hits           8228     8228              
- Misses         1790     1791       +1     
  Partials        240      240              
Flag Coverage Δ
cpp 71.49% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy warnings and enable be triggered by CI

2 participants

Comments