fix(C++): fix all enumerations to use strongly-typed enums (enum class)#869
Open
SYaoJun wants to merge 1 commit intoapache:mainfrom
Open
fix(C++): fix all enumerations to use strongly-typed enums (enum class)#869SYaoJun wants to merge 1 commit intoapache:mainfrom
SYaoJun wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
============================================
- Coverage 80.21% 80.20% -0.01%
Complexity 615 615
============================================
Files 93 93
Lines 10258 10259 +1
Branches 1050 1050
============================================
Hits 8228 8228
- Misses 1790 1791 +1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
fix: #855
Currently, our enum mixed with C-type and strongly-type. C-type enums exists implicit convertion which may lead to potential bugs in some scenerios. A better way is using strongly-type enums.
What changes are included in this PR?
Fix all C-type enums.
Are these changes tested?
N/A
Are there any user-facing changes?
N/A