Review Comments fix:replace if/else with switch in DMNCompilerImpl class

apache · Mar 7, 2025 · bce987f · bce987f
1 parent 45658fe
commit bce987f
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNCompilerImpl.java b/kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNCompilerImpl.java
@@ -229,13 +229,18 @@ private DMNCompilerContext configureDMNCompiler(FEELDialect feeldialect, Functio
     private void iterateImports(Definitions dmndefs, Collection<DMNModel> dmnModels, DMNModelImpl model, Function<String, Reader> relativeResolver ) {
         List<DMNModel> toMerge = new ArrayList<>();
         for (Import i : dmndefs.getImport()) {
-            if (ImportDMNResolverUtil.whichImportType(i) == ImportType.DMN) {
-                resolveDMNImportType(i, dmnModels, model, toMerge );
-            } else if (ImportDMNResolverUtil.whichImportType(i) == ImportType.PMML) {
-                processPMMLImport(model, i, relativeResolver);
-                model.setImportAliasForNS(i.getName(), i.getNamespace(), i.getName());
-            } else {
-                logErrorMessage(model, i.getImportType());
+            ImportType importType = ImportDMNResolverUtil.whichImportType(i);
+            switch(importType) {
+                case DMN :
+                    resolveDMNImportType(i, dmnModels, model, toMerge);
+                    break;
+                case PMML:
+                    processPMMLImport(model, i, relativeResolver);
+                    model.setImportAliasForNS(i.getName(), i.getNamespace(), i.getName());
+                    break;
+                default :
+                    logErrorMessage(model, i.getImportType());
+                    break;
             }
         }
         toMerge.forEach(mergedModel -> processMergedModel(model, (DMNModelImpl) mergedModel));