[incubator-kie-issues-1752] TCK failure-Lambda function returns null #6261

bncriju · 2025-02-20T14:52:51Z

Added the fix for this problem and added test class and test methods to verify the same.

After and before the changes:

< "compliance-level-3/0092-feel-lambda","0092-feel-lambda-test-01","014","SUCCESS",""

"compliance-level-3/0092-feel-lambda","0092-feel-lambda-test-01","014","ERROR","FAILURE: 'decision_014_1' expected='25.0' but found='null'"

kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/lang/types/GenFnTypeTest.java

yesamer

Minor points to address (formatting)

yesamer · 2025-02-24T13:10:50Z

kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/types/GenFnType.java

@@ -1,4 +1,5 @@
-/**
+/*
+ *


@bncriju Please remove line 2

yesamer · 2025-02-24T13:11:12Z

kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/lang/types/GenFnTypeTest.java

@@ -0,0 +1,228 @@
+/*
+ *


@bncriju Please remove line 2

yesamer · 2025-02-24T13:12:09Z

kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/types/GenFnType.java

-                }
+        if (o instanceof FEELFunction oFn) {
+            List<List<Param>> parameters = oFn.getParameters();
+            if(parameters.isEmpty()){


Suggested change

if(parameters.isEmpty()){

if (parameters.isEmpty()) {

Please use the same formatting style of the code base

yesamer · 2025-02-24T13:12:59Z

kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/types/GenFnType.java

-                   IntStream.range(0, argsGen.size()).allMatch(i -> fnT.argsGen.get(i).conformsTo(this.argsGen.get(i))) &&
-                   this.returnGen.conformsTo(fnT.returnGen);
+                    IntStream.range(0, argsGen.size()).allMatch(i -> fnT.argsGen.get(i).conformsTo(this.argsGen.get(i))) &&
+                    this.returnGen.conformsTo(fnT.returnGen);
        } else {


@bncriju Please remove those 2 whitespaces

gitgabrio · 2025-02-25T08:15:57Z

kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/types/GenFnType.java

+            List<List<Param>> parameters = oFn.getParameters();
+            if(parameters.isEmpty()){
+                //this is used to consider function as parameter
+                return true;


HI @bncriju
on second thought, I think we need to implement more check here, i.e. if the expected input/output of the current GenFnType are compatible with invoke methods of the provided function

kie-ci3 · 2025-02-27T17:57:26Z

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6261 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6261/8/display/redirect

Test results:

PASSED: 23224
FAILED: 4

Those are the test failures:

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithNoParameters

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsAssignableValueWithFunction

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithMatchingFunctionSignature

Expecting value to be true but was false

org.kie.dmn.feel.runtime.functions.BaseFEELFunctionTest.testIsCompatible

Expecting value to be true but was false

# Conflicts: # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/RangeNode.java

kie-ci3 · 2025-03-03T21:19:50Z

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6261 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6261/11/display/redirect

Test results:

PASSED: 22368
FAILED: 3

Those are the test failures:

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithNoParameters

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsAssignableValueWithFunction

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithMatchingFunctionSignature

Expecting value to be true but was false

…validation file

kie-ci3 · 2025-03-04T15:04:20Z

PR job #12 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6261 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6261/12/display/redirect

Test results:

PASSED: 23238
FAILED: 3

Those are the test failures:

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithNoParameters

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsAssignableValueWithFunction

Expecting value to be true but was false

org.kie.dmn.feel.lang.types.GenFnTypeTest.testIsInstanceOfWithMatchingFunctionSignature

Expecting value to be true but was false

…TypeUtilsTest

kie-ci3 · 2025-03-06T15:14:50Z

PR job #17 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6261 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6261/17/display/redirect

Test results:

PASSED: 23245
FAILED: 1

Those are the test failures:

org.kie.dmn.feel.runtime.functions.BaseFEELFunctionTest.testIsCompatibleTrue

Expecting value to be true but was false

yesamer · 2025-03-07T11:31:25Z

@bncriju Can you please check why the builds are failing?

bncriju · 2025-03-07T15:11:48Z

Checked the build failures and found that this required changes in kogito runtimes repo. apache/incubator-kie-kogito-runtimes#3860 raised

bncriju added 3 commits February 20, 2025 20:16

null returned from lambda -issue fixed and added tests

404c291

Restored singleton patterns for functions used for test

f5731cd

Refactored test class and added more tests

367f0e1

yesamer reviewed Feb 24, 2025

View reviewed changes

kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/lang/types/GenFnTypeTest.java Show resolved Hide resolved

Added apache header on new class

8bc77b2

bncriju requested a review from yesamer February 24, 2025 08:57

baldimir approved these changes Feb 24, 2025

View reviewed changes

bncriju added 2 commits February 24, 2025 17:18

Merge remote-tracking branch 'origin/main' into kie-issues#1752

56620c8

making doc correct

5d4b68f

yesamer reviewed Feb 24, 2025

View reviewed changes

yesamer added the DMN label Feb 24, 2025

gitgabrio reviewed Feb 25, 2025

View reviewed changes

yesamer added the working_in_progress DO NOT MERGE! just testing PR label Feb 25, 2025

bncriju and others added 4 commits February 26, 2025 19:19

checking invoke method and incorporating review comments

c0123fb

Merge remote-tracking branch 'origin/main' into kie-issues#1752

5cb934c

[incubator-kie-issues#1752] WIP

61699e3

isCompatible method test and candidate method modification

17a8abb

gitgabrio marked this pull request as draft February 27, 2025 16:21

bncriju and others added 5 commits March 3, 2025 18:51

Util class added for BuiltInType. Used util method

6f56cfc

Merge remote-tracking branch 'origin/main' into kie-issues#1752

b2b0b03

# Conflicts: # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/RangeNode.java

resolved merge conflicts

fe19990

reverting pom changes

93e22ab

[incubator-kie-issues#1752] Improve parameters check on BaseFEELFunction

bc6e374

[incubator-kie-issues#1752] Fix usage of BuiltInTypeUtils inside drl …

0560f1f

…validation file

bncriju added 2 commits March 5, 2025 20:35

adding tests

7013c13

Merge remote-tracking branch 'origin/main' into kie-issues#1752

55d173b

bncriju marked this pull request as ready for review March 5, 2025 15:13

Gabriele-Cardosi and others added 3 commits March 5, 2025 17:40

[incubator-kie-issues#1752] WIP - Test suggestion

62ce7a1

test suggestions incorporated

365eb15

[incubator-kie-issues#1752] Managing arrays conversion. Begin BuiltIn…

4995fbd

…TypeUtilsTest

bncriju added 4 commits March 6, 2025 20:58

tests updated

a69fbe7

Merge remote-tracking branch 'origin/main' into kie-issues#1752

0cc7c2c

license header corrected and managed unused imports

5c44070

license header corrected

19fc323

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator-kie-issues-1752] TCK failure-Lambda function returns null #6261

[incubator-kie-issues-1752] TCK failure-Lambda function returns null #6261

bncriju commented Feb 20, 2025 •

edited

Loading

yesamer left a comment

yesamer Feb 24, 2025

yesamer Feb 24, 2025

yesamer Feb 24, 2025

yesamer Feb 24, 2025

gitgabrio Feb 25, 2025

kie-ci3 commented Feb 27, 2025

kie-ci3 commented Mar 3, 2025

kie-ci3 commented Mar 4, 2025

kie-ci3 commented Mar 6, 2025

yesamer commented Mar 7, 2025

bncriju commented Mar 7, 2025

@@ @@ -1,4 +1,5 @@ @@
-              /**
+              /*
+               *

[incubator-kie-issues-1752] TCK failure-Lambda function returns null #6261

Are you sure you want to change the base?

[incubator-kie-issues-1752] TCK failure-Lambda function returns null #6261

Conversation

bncriju commented Feb 20, 2025 • edited Loading

yesamer left a comment

Choose a reason for hiding this comment

yesamer Feb 24, 2025

Choose a reason for hiding this comment

yesamer Feb 24, 2025

Choose a reason for hiding this comment

yesamer Feb 24, 2025

Choose a reason for hiding this comment

yesamer Feb 24, 2025

Choose a reason for hiding this comment

gitgabrio Feb 25, 2025

Choose a reason for hiding this comment

kie-ci3 commented Feb 27, 2025

kie-ci3 commented Mar 3, 2025

kie-ci3 commented Mar 4, 2025

kie-ci3 commented Mar 6, 2025

yesamer commented Mar 7, 2025

bncriju commented Mar 7, 2025

bncriju commented Feb 20, 2025 •

edited

Loading