[incubator-kie-issues-1832] Adding Group node makes the validation to fail #6262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesamer
reviewed
Feb 24, 2025
...-validation/src/main/resources/org/kie/dmn/validation/DMNv1_2/dmn-validation-rules-dmndi.drl
Outdated
Show resolved
Hide resolved
...-validation/src/main/resources/org/kie/dmn/validation/DMNv1_2/dmn-validation-rules-dmndi.drl
Outdated
Show resolved
Hide resolved
…-issues#1832 # Conflicts: # kie-dmn/kie-dmn-validation/src/main/java/org/kie/dmn/validation/DMNValidatorImpl.java
yesamer
approved these changes
Feb 24, 2025
baldimir
approved these changes
Feb 25, 2025
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Mar 4, 2025
… fail (apache#6262) * update Group (and its children) with the id property and updated the rule * [incubator-kie-issues#1832] Declaring v1_3 kiebase for rule-based validation * [incubator-kie-issues#1832] Declaring v1_3 kiebase for rule-based validation * Adding test for checking model with group node * [incubator-kie-issues#1832] Add license to ModelWithGroupNode.dmn --------- Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1832
When validation parses the DMNShape, the engine seems unable to find the group.
Now, solved this issue by
1.updating Group (and its children) with the id property
2.updating the rules with the “not Group…” directive