[incubator-kie-drools-6265] Apache RAT check misses drools-model #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A temporary workaround until Apache RAT 0.17 will be released
|
The PR looks as working to me. |
jomarko
approved these changes
Mar 3, 2025
yesamer
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
@tkobayas Thank you. I just have a minor suggestion, writing something like "To be checked after apache-rat 0.17 release" just to make sure whoever will update to 0.17 will double-check if that workaround is still necessary.
tkobayas
commented
Mar 4, 2025
|
@yesamer Thanks. Applied the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: