[incubator-kie-issues#2361] fix log forging cwe#2347
Merged
Conversation
yesamer
approved these changes
Jul 8, 2026
josedee
approved these changes
Jul 9, 2026
Comment on lines
-56
to
+70
| + identifier.replace('\n', '_').replace('\r', '_') | ||
| + sanitize(identifier) | ||
| + ", graphQLDefinition=" | ||
| + graphQLDefinition.replace('\n', '_').replace('\r', '_') | ||
| + sanitize(graphQLDefinition) | ||
| + ", query=" | ||
| + query.replace('\n', '_').replace('\r', '_') | ||
| + sanitize(query) | ||
| + "]"; | ||
| } | ||
|
|
||
| private static String sanitize(String value) { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| return value.replaceAll("\\R+", "_"); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Thanks Athira. I haven't looked at the entire code, but this would also fix a possible NPE in the code.
There was a problem hiding this comment.
Pull request overview
This PR addresses CWE-117 (log forging) risk by sanitizing line-break characters in DataAuditQuery.toString() output so log entries cannot be split/injected via CR/LF or other Unicode line separators.
Changes:
- Centralized log-sanitization into a
sanitize(String)helper. - Replaced manual
\n/\rsubstitutions with\R+regex replacement to cover all line-break sequences (including Unicode). - Added null-safety to avoid potential
NullPointerExceptionintoString().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : apache/incubator-kie-issues#2361
Sanitize newline characters in DataAuditQuery.toString() to prevent log forging (CWE-117) by replacing all line-break sequences (\R+) with _, including null-safety and Unicode line separators.