NO-ISSUE: Upgrade maven to 3.9.9

[RishiRajAnand]

• We need to upgrade maven as we found some tests breaks during upgrading quarkus to 3.15 LTS
• More information on quarkus issue

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

• You have read the contributors guide
• Your code is properly formatted according to this configuration
• Pull Request title is properly formatted: Issue-XYZ Subject
• Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
• Pull Request contains link to the JIRA issue
• Pull Request contains link to any dependent or related Pull Request
• Pull Request contains description of the issue
• Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

[ricardozanini]

We also need to upgrade https://github.com/apache/incubator-kie-tools/ and link both PRs, check if everything is ok and then merge both.

Is https://github.com/apache/incubator-kie-kogito-apps/ affected too?

[yesamer]

I guess all repos require to be updated

e.g. https://github.com/apache/incubator-kie-drools/pull/5835/files

[gitgabrio]

Thanks @RishiRajAnand

As @yesamer said, we have to be sure that this is replicated all over our repos.
IINW, drools repo uses 3.8.6
At the same time, drools depends on Quarkus, so I guess it should also follow the samve modification.

Last (very side note: the common dependencies (as the maven version) should be declared in the top most pom/bom, and then inherited downward

@baldimir ^^

[thiagoelg]

Draft PR for kie-tools: apache/incubator-kie-tools#2871

[tiagobento]

@gitgabrio All repos that composed the Apache KIE 10.0.0 release are aligned to be on 3.9.6. Maybe READMEs are outdated, but every build verification was supposed to be using 3.9.6 as per our Release Procedure document.

@thiagoelg Thanks! I'll convert this PR to non-draft so that the PR checks run.

[gmunozfe]

Looks good to me, thanks @RishiRajAnand !

[gmunozfe]

Is https://github.com/apache/incubator-kie-kogito-apps/ affected too?

Yes
./.github/workflows/pr-downstream.yml: maven-version: ['3.9.6']
./.github/workflows/pr-kogito-apps.yml: maven-version: ['3.9.6']
./.github/workflows/publish-jitexecutor-native-rc.yml: maven-version: 3.9.6
./.github/workflows/publish-jitexecutor-native.yml: maven-version: 3.9.6

[RishiRajAnand]

FYI the issue that required us to update maven during quarkus upgrade is now fixed. We needed to update the maven-compiler-plugin to 3.13.0 to align with quarkus. see commit

[gitgabrio]

@tiagobento
Inside drools pom there is a
<version.org.apache.maven>3.8.6</version.org.apache.maven> (see my previous comment)
and this one is used in multiple places, to define the plugin/dependency version.

[tiagobento]

@gitgabrio That's for building drools itself or for the drools runtime? Those can be different...

[domhanak]

If we are upgrading our build tool version, please do so for whole ensemble of our stack. It is not good to have some of our repositories use different version of our build tool. It can lead to problems in resulting binaries.

Missing drools and apps, examples (so far they are not migrated). Kie-tools should probably be done week after the changes are present on java parts afaik.

[yesamer]

Overseeded by #4004. Closing