fix: manual compact unexpected start #1565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Aug 3, 2023
| std::atomic<int> _max_concurrent_running_count; | ||
| std::atomic<uint64_t> _manual_compact_first_day_s; |
There was a problem hiding this comment.
Could you please add some comments for the newly added variable?
The logic is too complex if adding these variables, if the current "periodic", "max_concurrent_running" features are not well implemented, I don't mind you to rewrite or even remove them.
acelyc111
reviewed
Aug 6, 2023
| for (auto t : trigger_time) { | ||
| auto t_ms = t * 1000; | ||
|
|
||
| if (_manual_compact_first_day_s.load() == cur_day_midnight && t_ms < now && |
There was a problem hiding this comment.
It's allowed to set multiple periodic compact tasks on a table, for example there are 2 tasks set to be executed at 02:00 and 16:00, now real world time is 15:00, will the second task (16:00 one) to be executed normally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1564
What is changed and how does it work?
My modifications mainly focus on
pegasus_manual_compact_service::check_periodic_compact. When the user setsMANUAL_COMPACT_PERIODIC_TRIGGER_TIME_KEYfor the first time inapp_envs, the midnight of the date on which the time is set is recorded.If the user sets the trigger time to 02:00 and the current time is 15:00, they want to perform manual_compact again at 02:00 the next day.
_manual_compact_first_day_s.load() == cur_day_midnight && t_ms < noweffectively restricts manual_compact on the same day for the user.However, if the user sets the trigger time to 16:00 and the current time is still 15:00, it is obvious that the user wants to do manual_compact at 16:00 on the same day. The
_time_natural_increasemember variable resolves this situation by indicating that the time has naturally progressed under the current logic, rather than comparing it with the initialMANUAL_COMPACT_PERIODIC_TRIGGER_TIME_KEYsetting.Lastly, if the user deletes the
MANUAL_COMPACT_PERIODIC_TRIGGER_TIME_KEYparameter and then sets it again, it will be treated as the first-time setting.Checklist
Tests