refactor(FQDN): further more refator on idl/dsn.layer2.thrift #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
fqdn_partition_configuration_2
branch
from
94de408 to
e232ba6
Compare
acelyc111
force-pushed
the
fqdn_partition_configuration_2
branch
2 times, most recently
from
2284105 to
e04715e
Compare
acelyc111
changed the title
acelyc111
force-pushed
the
fqdn_partition_configuration_2
branch
5 times, most recently
from
a73ffe4 to
9b91b8a
Compare
|
Please ignore the clang-tidy errors, because there are so many errors, it would introduce too many clang-tidy related changes as well which may cause the main changes of this pull request hard to distinguish and review. |
Samunroyu
reviewed
Mar 13, 2025
acelyc111
force-pushed
the
fqdn_partition_configuration_2
branch
from
9b91b8a to
f9594e4
Compare
Samunroyu
previously approved these changes
Mar 16, 2025
acelyc111
pushed a commit
that referenced
this pull request
May 21, 2025
This is a further refactor on idl/dsn.layer2.thrift based on #2049 the main effects are on partition_configuration structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further refactor on idl/dsn.layer2.thrift, the main effects are on
partition_configuration structure.
To keep compatible and support rolling update, it should be accepted that partial
servers or clients with the FQDN supporting feature and partial of them without
the feature. In this patch, macros like
GET_HOST_PORTandGET_HOST_PORTSareused in almost all places where partition_configuration objects appear. (Unit
tests don't require this because the tests must in the latest version which has
this feature).
When invoking a RPC, it's preferred to use host_port because we suppose that the
IP address is possible to be changed, but the hostname is permanent.
When received a proposol request, the optional
hp_primaryandhp_secondarieswill be filled by the related host_ports of the
primaryandsecondariesandfields. Then we can simplily deal with the logic.