fix: deal with the race between duplication and on_checkpoint_timer #2212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#2211
What is changed and how does it work?
add lock when remove_all_duplication.
We can see
src/replica/duplication/replica_duplicator_manager.h, there are code comments like thisSo we need to perfect this lock's usage.
Checklist
Tests
How this PR work?
Possible conflict locations with on_checkpoint_timer: