Skip to content

fix(go-client): fix the data race issue caused by concurrent read/write access to the session list of metaCall #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented May 23, 2025

Fix #2256.

The data race was caused by:

  1. The issueBackupMetas() function returns without waiting for all subroutines
    to complete;
  2. Concurrent access (read/write) to the metas member (the session list) of the
    metaCall struct was not properly synchronized with mutual exclusion.

@empiredan empiredan added the go Pull requests that update Go code label May 23, 2025
@empiredan empiredan changed the title fix(go-client): fix the data race issue caused by concurrent access to the metaSession member of metaCall fix(go-client): fix the data race issue caused by concurrent read/write access to the session list of metaCall May 26, 2025
@empiredan empiredan marked this pull request as ready for review May 26, 2025 04:34
@empiredan empiredan merged commit 06e06d4 into apache:master May 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code go-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta session test failed due to data race
3 participants