Skip to content

fix issues in NOTICE#178

Merged
cjcchen merged 2 commits into
apache:masterfrom
pjfanning:patch-1
Jun 28, 2025
Merged

fix issues in NOTICE#178
cjcchen merged 2 commits into
apache:masterfrom
pjfanning:patch-1

Conversation

@pjfanning

@pjfanning pjfanning commented Jun 28, 2025

Copy link
Copy Markdown
Member

This is a release blocker. If you are in Incubating project, that needs be mentioned in your NOTICE.

Here's an example of Fory's NOTICE.
https://github.com/apache/fory/blob/main/NOTICE

I'm not going to create equivalent PRs in all your other Git repos but someone in the PPMC should update their NOTICE files too.
https://incubator.apache.org/clutch/resilientdb.html

@pjfanning

Copy link
Copy Markdown
Member Author

@cjcchen the year is still wrong - it is 2025

@cjcchen cjcchen merged commit 7a1eafc into apache:master Jun 28, 2025
2 checks passed
@pjfanning pjfanning deleted the patch-1 branch June 28, 2025 10:50
@pjfanning

Copy link
Copy Markdown
Member Author

@cjcchen could you update the NOTICE on all of your git repos? You'll find them listed in https://incubator.apache.org/clutch/resilientdb.html

@cjcchen

cjcchen commented Jun 28, 2025

Copy link
Copy Markdown
Contributor

@cjcchen could you update the NOTICE on all of your git repos? You'll find them listed in https://incubator.apache.org/clutch/resilientdb.html

Hi PJ,
Yes. I have updated all.

Thanks a lot.

@pjfanning

Copy link
Copy Markdown
Member Author

@cjcchen could you update the NOTICE on all of your git repos? You'll find them listed in https://incubator.apache.org/clutch/resilientdb.html

Hi PJ, Yes. I have updated all.

Thanks a lot.

@cjcchen I have checked some git repos and they were not updated. I assume that you are hand modifying the files as part of creating the release. This is problematic.

  • The files might not be correct for future RCs as the release manager might forget to hand modify them
  • If the release manager is hand modifying the files in the source release, what is to say that they are not modifying other files
  • most RCs contain commit IDs and possibly git tags so that people verifying the releases can verify that the release manager is not hand modifying files - it really breaks the circle of trust - and it is important build is reproducible - that someone else could build the release and you would get the same artifacts

@cjcchen

cjcchen commented Jun 28, 2025

Copy link
Copy Markdown
Contributor

@cjcchen could you update the NOTICE on all of your git repos? You'll find them listed in https://incubator.apache.org/clutch/resilientdb.html

Hi PJ, Yes. I have updated all.
Thanks a lot.

@cjcchen I have checked some git repos and they were not updated. I assume that you are hand modifying the files as part of creating the release. This is problematic.

  • The files might not be correct for future RCs as the release manager might forget to hand modify them
  • If the release manager is hand modifying the files in the source release, what is to say that they are not modifying other files
  • most RCs contain commit IDs and possibly git tags so that people verifying the releases can verify that the release manager is not hand modifying files - it really breaks the circle of trust - and it is important build is reproducible - that someone else could build the release and you would get the same artifacts

Hi PJ,

Thanks for the clarification.
I have committed the updates while creating the release RC2.

I will double-check again if I miss some and attach the commit IDs in the threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants